Bug #89384 for File-Temp: Missing test dependencies

Thu Oct 10 07:40:32 2013 ppisar [...] redhat.com - Ticket created

Subject:

Missing test dependencies

The 0.2303 removed all test dependencies: --- File-Temp-0.2302/Makefile.PL 2013-09-26 15:45:39.000000000 +0200 +++ File-Temp-0.2303/Makefile.PL 2013-10-09 15:57:25.000000000 +0200 @@ -26,14 +26,8 @@ "File::Spec" => "0.8", "parent" => "0.221" }, - "TEST_REQUIRES" => { - "File::Spec" => 0, - "File::Temp" => 0, - "IO::Handle" => 0, - "IPC::Open3" => 0, - "Test::More" => 0 - }, - "VERSION" => "0.2302", + "TEST_REQUIRES" => {}, + "VERSION" => "0.2303", "test" => { "TESTS" => "t/*.t" } which is wrong. File::Temp is still used at t/fork.t:23, Test::More at t/00-report-prereqs.t:6.

Thu Oct 10 08:52:29 2013 dagolden [...] cpan.org - Correspondence added

On Thu Oct 10 07:40:32 2013, ppisar wrote: Show quoted text

> which is wrong. > > File::Temp is still used at t/fork.t:23, Test::More at t/00-report- > prereqs.t:6.

Let me get this straight: you're telling me that we should list File::Temp as a dependency of File::Temp? How, exactly, do you expect a CPAN client to resolve that dependency? Is anything actually failing for you or are you just being pedantic? Test::More was core in v5.6.1 and if you're running something older than that, well, best of luck. You're well out of the support window for both Perl itself and the Perl toolchain (which now targets v5.8.1). I may add Test::More back just for clarity, but I seriously doubt it's an issue in practice.

Thu Oct 10 08:52:29 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 10 08:52:30 2013 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Oct 10 09:09:23 2013 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #89384] Missing test dependencies
Date:	Thu, 10 Oct 2013 15:08:33 +0200
To:	David Golden via RT <bug-File-Temp [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Thu, Oct 10, 2013 at 08:52:30AM -0400, David Golden via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=89384 > > > On Thu Oct 10 07:40:32 2013, ppisar wrote:

> > which is wrong. > > > > File::Temp is still used at t/fork.t:23, Test::More at t/00-report- > > prereqs.t:6.

> > Let me get this straight: you're telling me that we should list File::Temp > as a dependency of File::Temp? How, exactly, do you expect a CPAN client to > resolve that dependency? >

Sorry. This was a my mistake. Show quoted text

> Is anything actually failing for you or are you just being pedantic? >

Pedantic. Show quoted text

> Test::More was core in v5.6.1 and if you're running something older than > that, well, best of luck. You're well out of the support window for both > Perl itself and the Perl toolchain (which now targets v5.8.1). >

You list core modules in PREREQ_PM too, so I guessed you removed the Test::More from TEST_REQUIRES unintentionally. Otherwise you can delist Fcntl 1.03 because core v5.8.1 provides version 1.05. Similar applies to File::Spec 0.8. -- Petr

Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

Thu Oct 10 09:14:47 2013 dagolden [...] cpan.org - Correspondence added

On Thu Oct 10 09:09:23 2013, ppisar wrote: Show quoted text

> Otherwise you can delist Fcntl 1.03 because core v5.8.1 provides > version 1.05. > Similar applies to File::Spec 0.8.

I'm actually going to go the other way. I've switched on prereq autodetection and made the other patches necessary for that not to get confused. (E.g. only requiring VMS::Stdio on VMS). So we'll get *everything* (except File::Temp itself) listed auto-pedantically so we don't have to think about it. :-) Thank you for pointing out the unintentional Test::More change. That actually happened a few versions back and got masked by other changes that were reverted in the last version released. David