Bug #89371 for MailTools: format In-Reply-To header according to current best practices

Wed Oct 09 20:46:13 2013 ward [...] gnu.org - Ticket created

Subject:	format In-Reply-To header according to current best practices
Date:	Wed, 9 Oct 2013 20:45:53 -0400
To:	bug-MailTools [...] rt.cpan.org
From:	Ward Vandewege <ward [...] gnu.org>

Cf: http://tools.ietf.org/html/rfc5322#section-3.2.2 this patch puts the comments in the In-Reply-To header in parentheses. Thanks, Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859

Message body is not shown because sender requested not to inline it.

Thu Oct 10 03:13:27 2013 solutions [...] overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date:	Thu, 10 Oct 2013 09:12:58 +0200
To:	Ward Vandewege via RT <bug-MailTools [...] rt.cpan.org>
From:	Mark Overmeer <solutions [...] overmeer.net>

* Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 00:46]: Show quoted text

> Wed Oct 09 20:46:13 2013: Request 89371 was acted upon. > Transaction: Ticket created by ward@gnu.org > Queue: MailTools > Subject: format In-Reply-To header according to current best practices > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ward@gnu.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89371 > > > http://tools.ietf.org/html/rfc5322#section-3.2.2 > > this patch puts the comments in the In-Reply-To header in parentheses.

Ok. Show quoted text

> + $inreply .= ' (' if (defined $name or defined $date); > + $inreply .= 'from ' . $name if defined $name; > + $inreply .= 'on ' . $date if defined $date; > + $inreply .= ')' if (defined $name or defined $date);

This would glue the "on" to $name if both $name and $date are set. I have changed it into: if(defined $mid) { $inreply = $mid; my @comment; push @comment, "from $name" if defined $name; push @comment, "on $date" if defined $date; local $" = ' '; $inreply .= " (@comment)" if @comment; } Do you need this to be released soon? -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Thu Oct 10 03:13:27 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 10 10:08:32 2013 ward [...] gnu.org - Correspondence added

Subject:	Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date:	Thu, 10 Oct 2013 10:08:08 -0400
To:	Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From:	Ward Vandewege <ward [...] gnu.org>

On Thu, Oct 10, 2013 at 03:13:27AM -0400, Mark Overmeer via RT wrote: Show quoted text

> > + $inreply .= ' (' if (defined $name or defined $date); > > + $inreply .= 'from ' . $name if defined $name; > > + $inreply .= 'on ' . $date if defined $date; > > + $inreply .= ')' if (defined $name or defined $date);

> > This would glue the "on" to $name if both $name and $date are set. > I have changed it into: > > if(defined $mid) > { $inreply = $mid; > my @comment; > push @comment, "from $name" if defined $name; > push @comment, "on $date" if defined $date; > local $" = ' '; > $inreply .= " (@comment)" if @comment; > }

Ah, that's much better. Thanks. Show quoted text

> Do you need this to be released soon?

I've patched our copy, there is no great urgency. Do you have a timeline in mind for a release? Thanks, Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859

Thu Oct 10 10:10:25 2013 Mark [...] Overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date:	Thu, 10 Oct 2013 16:10:00 +0200
To:	Ward Vandewege via RT <bug-MailTools [...] rt.cpan.org>
From:	Mark Overmeer <mark [...] overmeer.net>

* Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 14:08]: Show quoted text

> I've patched our copy, there is no great urgency. Do you have a timeline in > mind for a release?

That module is very old and very stable. I usually collect a few patches per release.... which can take months... unless you desparately need it. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Thu Oct 10 10:50:31 2013 ward [...] gnu.org - Correspondence added

Subject:	Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date:	Thu, 10 Oct 2013 10:50:06 -0400
To:	Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From:	Ward Vandewege <ward [...] gnu.org>

On Thu, Oct 10, 2013 at 10:10:26AM -0400, Mark Overmeer via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=89371 > > > * Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 14:08]:

> > I've patched our copy, there is no great urgency. Do you have a timeline in > > mind for a release?

> > That module is very old and very stable. I usually collect a few > patches per release.... which can take months... unless you > desparately need it.

No desperation here; that sounds like a fine plan. Thanks! Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859

Fri Oct 10 14:16:50 2014 MARKOV [...] cpan.org - Correspondence added

fixed in 2.13

Fri Oct 10 14:16:51 2014 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'