Bug #89274 for Parse-HTTP-UserAgent: Parse-HTTP-UserAgent fails to pass tests as of 0.37

Sun Oct 06 04:08:12 2013 rob [...] hoelz.ro - Ticket created

Subject:

Parse-HTTP-UserAgent fails to pass tests as of 0.37

I get the following failure when I try to install Parse-HTTP-UserAgent, versions 0.37 or 0.38: # Failed test 'No data in the test result set? Expected something matching with these: # \# # # extras => [], # name => '\#', # parser => 'moz_only', # string_original => '\#', # version_raw => 0, # ' # at t/02-parser.t line 45. # Looks like you failed 1 test of 755. I've attached the full build.log file from cpanminus as well.

Subject:

build.log

cpanm (App::cpanminus) 1.6911 on perl 5.018001 built for x86_64-linux Work directory is /home/rob/.cpanm/work/1381046375.20890 You have make /usr/bin/make You have LWP 6.05 You have /usr/bin/tar: tar (GNU tar) 1.26 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. You have /usr/bin/unzip Searching Parse::HTTP::UserAgent on cpanmetadb ... --> Working on Parse::HTTP::UserAgent Fetching file:///home/rob/minicpan/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz -> FAIL Download file:///home/rob/minicpan/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz failed. Retrying ... -> FAIL Download file:///home/rob/minicpan/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz failed. Retrying ... -> FAIL Download file:///home/rob/minicpan/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz failed. Retrying ... -> FAIL Failed to download file:///home/rob/minicpan/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz Fetching http://cpan.mirror.triple-it.nl/authors/id/B/BU/BURAK/Parse-HTTP-UserAgent-0.38.tar.gz -> OK Unpacking Parse-HTTP-UserAgent-0.38.tar.gz Entering Parse-HTTP-UserAgent-0.38 Checking configure dependencies from META.json Checking if you have Module::Build 0.40 ... Yes (0.4003) Configuring Parse-HTTP-UserAgent-0.38 Running Build.PL Created MYMETA.yml and MYMETA.json Creating new 'Build' script for 'Parse-HTTP-UserAgent' version '0.38' -> OK Checking dependencies from MYMETA.json ... Checking if you have version 0 ... Yes (0.9902) Checking if you have Test::More 0.40 ... Yes (0.98) Building and testing Parse-HTTP-UserAgent-0.38 Building Parse-HTTP-UserAgent # Failed test 'No data in the test result set? Expected something matching with these: # \# # # extras => [], # name => '\#', # parser => 'moz_only', # string_original => '\#', # version_raw => 0, # ' # at t/02-parser.t line 45. # Looks like you failed 1 test of 755. t/02-parser.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/755 subtests t/03-strings.t .. ok Test Summary Report ------------------- t/02-parser.t (Wstat: 256 Tests: 755 Failed: 1) Failed test: 107 Non-zero exit status: 1 Files=2, Tests=2393, 1 wallclock secs ( 0.19 usr 0.01 sys + 0.51 cusr 0.01 csys = 0.72 CPU) Result: FAIL Failed 1/2 test programs. 1/2393 subtests failed.

Mon Oct 07 19:51:36 2013 burak [...] cpan.org - Correspondence added

06 Eki 2013 Pzr, 04:08:12 tarihinde, hoelzro yazdı: Show quoted text

> I get the following failure when I try to install Parse-HTTP- > UserAgent, versions 0.37 or 0.38: > > # Failed test 'No data in the test result set? Expected something > matching with these: > # \# > # > # extras => [], > # name => '\#', > # parser => 'moz_only', > # string_original => '\#', > # version_raw => 0, > # ' > # at t/02-parser.t line 45. > # Looks like you failed 1 test of 755. > > I've attached the full build.log file from cpanminus as well.

Hmmm... Interesting. Seems like there is a problem with line endings, as the code should be skipping lines starting with hashes. However, I can't reproduce and I didn't get any fails from CPAN testers yet. Can you try this and tell me if it fixes the issue? diff -r 60b9b36eb72e t/db.pl --- a/t/db.pl Mon Sep 16 07:46:12 2013 +0200 +++ b/t/db.pl Tue Oct 08 01:43:42 2013 +0200 @@ -116,6 +116,9 @@ my $FH = IO::File->new; $FH->open( $file, 'r') or croak sprintf 'Can not open DB @ %s: %s', $file, $!; + if ( $] >= 5.008 ) { + eval q{binmode $FH, ':raw'; 1} or warn "Unable to set iolayer"; + } or just binmode FH;

Mon Oct 07 19:51:36 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Oct 07 19:51:36 2013 burak [...] cpan.org - Taken

Tue Oct 08 15:02:49 2013 rob [...] hoelz.ro - Correspondence added

From:

rob [...] hoelz.ro

On Mon Oct 07 19:51:36 2013, BURAK wrote: Show quoted text

> 06 Eki 2013 Pzr, 04:08:12 tarihinde, hoelzro yazdı:

> > I get the following failure when I try to install Parse-HTTP- > > UserAgent, versions 0.37 or 0.38: > > > > # Failed test 'No data in the test result set? Expected something > > matching with these: > > # \# > > # > > # extras => [], > > # name => '\#', > > # parser => 'moz_only', > > # string_original => '\#', > > # version_raw => 0, > > # ' > > # at t/02-parser.t line 45. > > # Looks like you failed 1 test of 755. > > > > I've attached the full build.log file from cpanminus as well.

> > Hmmm... Interesting. Seems like there is a problem with line endings, > as the code should be skipping lines starting with hashes. However, > I can't reproduce and I didn't get any fails from CPAN testers yet. > > Can you try this and tell me if it fixes the issue? > > diff -r 60b9b36eb72e t/db.pl > --- a/t/db.pl Mon Sep 16 07:46:12 2013 +0200 > +++ b/t/db.pl Tue Oct 08 01:43:42 2013 +0200 > @@ -116,6 +116,9 @@ > my $FH = IO::File->new; > $FH->open( $file, 'r') > or croak sprintf 'Can not open DB @ %s: %s', $file, $!; > + if ( $] >= 5.008 ) { > + eval q{binmode $FH, ':raw'; 1} or warn "Unable to set iolayer"; > + } > > or just binmode FH;

That didn't do it. =( If I Data::Printer the failing test (which is the only test data that fails), I get this: { id => 36, string => "#", struct => undef }

Mon Nov 11 13:26:35 2013 burak [...] cpan.org - Correspondence added

08 Eki 2013 Sal, 15:02:49 tarihinde, hoelzro yazdı: Show quoted text

> On Mon Oct 07 19:51:36 2013, BURAK wrote:

> > 06 Eki 2013 Pzr, 04:08:12 tarihinde, hoelzro yazdı:

> > > I get the following failure when I try to install Parse-HTTP- > > > UserAgent, versions 0.37 or 0.38: > > > > > > # Failed test 'No data in the test result set? Expected something > > > matching with these: > > > # \# > > > # > > > # extras => [], > > > # name => '\#', > > > # parser => 'moz_only', > > > # string_original => '\#', > > > # version_raw => 0, > > > # ' > > > # at t/02-parser.t line 45. > > > # Looks like you failed 1 test of 755. > > > > > > I've attached the full build.log file from cpanminus as well.

> > > > Hmmm... Interesting. Seems like there is a problem with line endings, > > as the code should be skipping lines starting with hashes. However, > > I can't reproduce and I didn't get any fails from CPAN testers yet. > > > > Can you try this and tell me if it fixes the issue? > > > > diff -r 60b9b36eb72e t/db.pl > > --- a/t/db.pl Mon Sep 16 07:46:12 2013 +0200 > > +++ b/t/db.pl Tue Oct 08 01:43:42 2013 +0200 > > @@ -116,6 +116,9 @@ > > my $FH = IO::File->new; > > $FH->open( $file, 'r') > > or croak sprintf 'Can not open DB @ %s: %s', $file, $!; > > + if ( $] >= 5.008 ) { > > + eval q{binmode $FH, ':raw'; 1} or warn "Unable to set > > iolayer"; > > + } > > > > or just binmode FH;

> > That didn't do it. =( If I Data::Printer the failing test (which is > the only test data that fails), I get this: > > { > id => 36, > string => "#", > struct => undef > }

Hi Rob, As I said, the input seems to be garbled and it can't map the lines correctly as I see. But I can't reproduce the issue and neither the CPAN Testers as there are no fails related to it. If this is happening in your laptop, find me in person and perhaps I can take a look ;) But I can't fix an issue I can't create myself. So, I'm closing this one. Thanks, Burak

Mon Nov 11 13:26:35 2013 burak [...] cpan.org - Status changed from 'open' to 'rejected'

Sun Dec 01 20:22:58 2013 burak [...] cpan.org - Correspondence added

Fixed in v0.39

Sun Dec 01 20:22:58 2013 burak [...] cpan.org - Status changed from 'rejected' to 'resolved'