Skip Menu |

This queue is for tickets about the Net-SFTP-Foreign CPAN distribution.

Report information
The Basics
Id: 89210
Status: rejected
Priority: 0/
Queue: Net-SFTP-Foreign

People
Owner: Nobody in particular
Requestors: tmetro [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.75
Fixed in: (no value)



Subject: autodie has limited use if it can't be overriden
Your documentation says: "The autodie mode will be disabled when an on_error handler is passed to methods accepting it." Yet it seems you have many methods that don't accept an on_error handler, such as stat(). It seems that for consistency, all methods should accept it, or there should be a method to disable autodie mode, or merely the ability to pass autodie => 0 to any method. (I suppose wrapping the odd method in eval {} is one way to work around this.)
On Wed Oct 02 15:54:59 2013, TMETRO wrote: Show quoted text
> Your documentation says: > > "The autodie mode will be disabled when an on_error handler is passed > to methods accepting it." > > Yet it seems you have many methods that don't accept an on_error > handler, such as stat(). It seems that for consistency, all methods > should accept it,
IMO It is already pretty consistent. The methods accepting the on_error handler are those that may perform several operations that may fail individually without aborting the main method. Specifically, IIRC, that means recursive and glob'ing methods. Show quoted text
> or there should be a method to disable autodie mode, > or merely the ability to pass autodie => 0 to any method.
Well, that makes sense. I have added it to the TODO list.