Bug #89104 for Tickit-Widget-Tabbed: Widget class not passed to ->new

Tue Oct 01 08:59:37 2013 TEAM [...] cpan.org - Ticket created

Subject:

Widget class not passed to ->new

This looks like an oversight - seems that passing the usual class/classes parameter to ->new does nothing, since we're not passing %args up to the ::Widget ->SUPER::new call. Makes styling a bit tricky for the rare cases when there are multiple tabbed widgets on the same page... cheers, Tom

Sun Oct 06 10:13:09 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Tue Oct 01 08:59:37 2013, TEAM wrote: Show quoted text

> This looks like an oversight - seems that passing the usual > class/classes parameter to ->new does nothing, since we're not passing > %args up to the ::Widget ->SUPER::new call. Makes styling a bit tricky > for the rare cases when there are multiple tabbed widgets on the same > page...

Oh yes. Simple fix; patch attached. -- Paul Evans

Subject:

rt89104.patch

=== modified file 'lib/Tickit/Widget/Tabbed.pm' --- lib/Tickit/Widget/Tabbed.pm 2013-08-31 20:49:09 +0000 +++ lib/Tickit/Widget/Tabbed.pm 2013-10-06 14:02:42 +0000 @@ -120,7 +120,7 @@ sub new { my $class = shift; my %args = @_; - my $self = $class->SUPER::new; + my $self = $class->SUPER::new(%args); $self->{tab_class} = delete($args{tab_class}); $self->{ribbon_class} = delete($args{ribbon_class});

Sun Oct 06 10:13:09 2013 The RT System itself - Status changed from 'new' to 'open'

Sun Oct 06 10:13:10 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Thu Nov 07 08:19:37 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Fixed in 0.011 -- Paul Evans

Thu Nov 07 08:19:38 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Thu Nov 07 08:19:38 2013 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.011 added