Skip Menu |

This queue is for tickets about the File-Map CPAN distribution.

Report information
The Basics
Id: 89101
Status: resolved
Priority: 0/
Queue: File-Map

People
Owner: Nobody in particular
Requestors: sisyphus [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.60
Fixed in: (no value)



Subject: [MS Windows] Not all (if any) MS compilers define ULLONG_MAX
Hi, The subject pretty much says it all. Here's the patch I applied to Map.xs to enable 0.60 to build using my x64 Platform SDK compiler: --- lib/File/Map.xs_orig 2013-10-01 21:19:08 +1000 +++ lib/File/Map.xs 2013-10-01 21:21:17 +1000 @@ -545,7 +545,11 @@ } #if defined(WIN32) || defined(__CYGWIN__) +#ifndef ULLONG_MAX +#define PTR_MAX _UI64_MAX /* MS Platform SDK crt */ +#else #define PTR_MAX ULLONG_MAX +#endif #else #define PTR_MAX ULONG_MAX #endif Cheers, Rob
On Tue Oct 01 07:35:48 2013, SISYPHUS wrote: Show quoted text
> Hi, > > The subject pretty much says it all. Here's the patch I applied to > Map.xs to enable 0.60 to build using my x64 Platform SDK compiler: > > --- lib/File/Map.xs_orig 2013-10-01 21:19:08 +1000 > +++ lib/File/Map.xs 2013-10-01 21:21:17 +1000 > @@ -545,7 +545,11 @@ > } > > #if defined(WIN32) || defined(__CYGWIN__) > +#ifndef ULLONG_MAX > +#define PTR_MAX _UI64_MAX /* MS Platform SDK crt */ > +#else > #define PTR_MAX ULLONG_MAX > +#endif > #else > #define PTR_MAX ULONG_MAX > #endif > > Cheers, > Rob
I applied this patch, and improved it a little more by using the non-ULONG_MAX logic only on 64 bit computers. Released as part of 0.61 Leon