Skip Menu |

This queue is for tickets about the Image-MetaData-JPEG CPAN distribution.

Report information
The Basics
Id: 89021
Status: resolved
Priority: 0/
Queue: Image-MetaData-JPEG

People
Owner: Nobody in particular
Requestors: wyant [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.153
Fixed in: 0.154



Subject: t/JPEG_p_podchecker.t fails because of non-ASCII characters in POD
I get the following error when I run the tests: t/JPEG_p_podchecker.t ...... # Checking documentation syntax with Pod::Checker *** ERROR: Non-ASCII character seen before =encoding in 'M?ller'. Assuming ISO8859-1 at line 1544 in file lib/Image/MetaData/JPEG.pod t/JPEG_p_podchecker.t ...... 1/4 # Failed test 'Checking lib/Image/MetaData/JPEG.pod' # at t/JPEG_p_podchecker.t line 26. # got: '1' # expected: '0' *** ERROR: Non-ASCII character seen before =encoding in 'Comit?'. Assuming ISO8859-1 at line 633 in file lib/Image/MetaData/JPEG/Structures.pod # Failed test 'Checking lib/Image/MetaData/JPEG/Structures.pod' # at t/JPEG_p_podchecker.t line 26. # got: '1' # expected: '0' # Looks like you failed 2 tests of 4. t/JPEG_p_podchecker.t ...... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/4 subtests Applying the attached patches silences the errors. The POD still renders strangely, though. I have marked this "Unimportant" because the failure is clearly not related to module functionality, and the install can always be forced. I am running: Perl 5.18.1 Pod::Checker 1.70 OS Darwin 12.5.0 (Mac OS 10.8.5)
Subject: Image-MetaData-JPEG-Structures-pod.patch
--- lib/Image/MetaData/JPEG/Structures.old 2006-05-13 07:18:50.000000000 -0400 +++ lib/Image/MetaData/JPEG/Structures.pod 2013-09-29 00:21:40.000000000 -0400 @@ -10,6 +10,8 @@ # type "perldoc <name_of_this_file>". # ########################################################### +=encoding iso-8859-1 + =head1 NAME Image::MetaData::JPEG::Structures - This document describes the structure
Subject: Image-MetaData-JPEG-pod.patch
--- lib/Image/MetaData/JPEG.old 2006-05-14 13:26:55.000000000 -0400 +++ lib/Image/MetaData/JPEG.pod 2013-09-29 00:20:58.000000000 -0400 @@ -10,6 +10,8 @@ # type "perldoc <name_of_this_file>". # ########################################################### +=encoding iso-8859-1 + =head1 NAME Image::MetaData::JPEG - Perl extension for showing/modifying JPEG (meta)data.
This bug is preventing the module from installing normally via CPAN. I'd be happy to build a this-fix-only release for you if it would help get the bugfix onto CPAN. Please let me know! -- rjbs
Subject: Re: [rt.cpan.org #89021] t/JPEG_p_podchecker.t fails because of non-ASCII characters in POD
Date: Sat, 16 Nov 2013 15:28:18 +0000
To: bug-Image-MetaData-JPEG [...] rt.cpan.org
From: Stefano Bettelli <stefano_bettelli [...] yahoo.fr>
On sab, 2013-11-16 at 08:13 -0500, Ricardo Signes via RT wrote: Show quoted text
> Queue: Image-MetaData-JPEG > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89021 > > This bug is preventing the module from installing normally via > CPAN. I'd be happy to build a this-fix-only release for you if > it would help get the bugfix onto CPAN. > Please let me know!
Hi, since I am currently too busy to look after this package I would really welcome someone volunteering to fix the annoying podchecker message. In fact, it would be a good idea to find someone with more time than me as a new maintainer and developer. The errors are related to non-ASCII characters in .pod files. Line 1544 in lib/Image/MetaData/JPEG.pod =item "libexif" by Lutz Müller and line 633 in lib/Image/MetaData/JPEG/Structures.pod Comité International des Télécommunications de Presse> the "offending" characters are of course the u-umlaut and the accented e's. Probably one just needs to change the encoding of the file, but I have no time to look into it right now. Please go ahead with the bug-fix release, and thank you. Best regards, Stefano Bettelli
Hi again, if you proceed with a bug-fix release, could you also implement the change proposed in ticket 78654 (a one-character fix indeed). Thanks
thanks, fixed! -- rjbs