Skip Menu |

This queue is for tickets about the Math-Interpolate CPAN distribution.

Report information
The Basics
Id: 89020
Status: resolved
Priority: 0/
Queue: Math-Interpolate
People
Owner: Nobody in particular
Requestors: g.grigelionis [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 1.00
  • 1.01
  • 1.02
  • 1.03
  • 1.04
  • 1.05
Fixed in: 1.06

History Show all quoted text
  Sat Sep 28 17:30:30 2013 g.grigelionis [...] gmail.com - Ticket created
Subject: Incorrect version causes warnings in cpan shell
Date: Sat, 28 Sep 2013 23:30:19 +0200
To: bug-Math-Interpolate [...] rt.cpan.org
From: Gintautas Grigelionis <g.grigelionis [...] gmail.com>
$VERSION = substr q$Revision: 1.05 $, 10; yields version number with a trailing space that current versions of cpan shell warn for Version string '1.05 ' contains invalid data; ignoring: ' ' at /Library/Perl/5.12/ExtUtils/MM_Unix.pm line 2707. A better solution is $VERSION = (qw$Revision: 1.05 $)[-1]; Regards, Gintas
  Wed Nov 06 13:32:49 2013 BZAJAC [...] cpan.org - Correspondence added
On Sat Sep 28 17:30:30 2013, g.grigelionis@gmail.com wrote: Show quoted text
> $VERSION = substr q$Revision: 1.05 $, 10; > > yields version number with a trailing space that current versions of > cpan shell warn for > > Version string '1.05 ' contains invalid data; ignoring: ' ' at > /Library/Perl/5.12/ExtUtils/MM_Unix.pm line 2707. > > A better solution is > > $VERSION = (qw$Revision: 1.05 $)[-1];
That code was originally there to support CVS and use its automatically managed Revision number bumping for each commit. Now that the project is hosted at github, I'm going to manually manage it. I'll be making this change: -$VERSION = substr q$Revision: 1.05 $, 10; +$VERSION = '1.06'; +$VERSION = eval $VERSION; BTW, is there a tool to bump $VERSION in all Perl files? I would like to bump to say '1.06_01' while its in development and then bump to '1.06' for the release and then go to '1.06_01'.
  Wed Nov 06 13:32:49 2013 The RT System itself - Status changed from 'new' to 'open'
  Wed Nov 06 15:51:19 2013 g.grigelionis [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #89020] Incorrect version causes warnings in cpan shell
Date: Wed, 6 Nov 2013 21:51:05 +0100
To: bug-Math-Interpolate [...] rt.cpan.org
From: Gintautas Grigelionis <g.grigelionis [...] gmail.com>
2013/11/6 BZAJAC via RT <bug-Math-Interpolate@rt.cpan.org> <URL: https://rt.cpan.org/Ticket/Display.html?id=89020 > Show quoted text
> > On Sat Sep 28 17:30:30 2013, g.grigelionis@gmail.com wrote:
> > $VERSION = substr q$Revision: 1.05 $, 10; > > > > yields version number with a trailing space that current versions of > > cpan shell warn for > > > > Version string '1.05 ' contains invalid data; ignoring: ' ' at > > /Library/Perl/5.12/ExtUtils/MM_Unix.pm line 2707. > > > > A better solution is > > > > $VERSION = (qw$Revision: 1.05 $)[-1];
> > That code was originally there to support CVS and use its automatically > managed Revision number bumping for each commit. Now that the project is > hosted at github, I'm going to manually manage it. I'll be making this > change: > > -$VERSION = substr q$Revision: 1.05 $, 10; > +$VERSION = '1.06'; > +$VERSION = eval $VERSION; > > BTW, is there a tool to bump $VERSION in all Perl files? I would like to > bump to say '1.06_01' while its in development and then bump to '1.06' for > the release and then go to '1.06_01'. > >
Great! Regarding tools, I saw a script once upon a time called "pervers", or something like that, but I guess that was before META.yml and META.json... Anyway, there are modules like Perl::Version or Version::Next, and some hints here: http://justatheory.com/computers/programming/perl/increment_version.html
  Sun Nov 10 02:45:40 2013 BZAJAC [...] cpan.org - Correspondence added
On Wed Nov 06 15:51:19 2013, g.grigelionis@gmail.com wrote: Show quoted text
> 2013/11/6 BZAJAC via RT <bug-Math-Interpolate@rt.cpan.org> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=89020 >
> > > > On Sat Sep 28 17:30:30 2013, g.grigelionis@gmail.com wrote:
> > > $VERSION = substr q$Revision: 1.05 $, 10; > > > > > > yields version number with a trailing space that current versions of > > > cpan shell warn for > > > > > > Version string '1.05 ' contains invalid data; ignoring: ' ' at > > > /Library/Perl/5.12/ExtUtils/MM_Unix.pm line 2707. > > > > > > A better solution is > > > > > > $VERSION = (qw$Revision: 1.05 $)[-1];
> > > > That code was originally there to support CVS and use its automatically > > managed Revision number bumping for each commit. Now that the project is > > hosted at github, I'm going to manually manage it. I'll be making this > > change: > > > > -$VERSION = substr q$Revision: 1.05 $, 10; > > +$VERSION = '1.06'; > > +$VERSION = eval $VERSION; > > > > BTW, is there a tool to bump $VERSION in all Perl files? I would like to > > bump to say '1.06_01' while its in development and then bump to '1.06' for > > the release and then go to '1.06_01'. > > > >
> Great! > > Regarding tools, I saw a script once upon a time called "pervers", or > something like that, but I guess that was before META.yml and META.json... > Anyway, there are modules like Perl::Version or Version::Next, and some > hints here: > http://justatheory.com/computers/programming/perl/increment_version.html
Thanks for the links. I'm trying to reproduce the error to make sure I get it right and my testing isn't printing any errors. What command are you using in the cpan shell? Also, what subroutine is line 2707 of MM_Unix.pm line? Thanks, Blair
  Sun Nov 10 05:41:31 2013 g.grigelionis [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #89020] Incorrect version causes warnings in cpan shell
Date: Sun, 10 Nov 2013 11:41:19 +0100
To: bug-Math-Interpolate [...] rt.cpan.org
From: Gintautas Grigelionis <g.grigelionis [...] gmail.com>
2013/11/10 BZAJAC via RT <bug-Math-Interpolate@rt.cpan.org> Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=89020 > > > On Wed Nov 06 15:51:19 2013, g.grigelionis@gmail.com wrote:
> > 2013/11/6 BZAJAC via RT <bug-Math-Interpolate@rt.cpan.org> > > > > <URL: https://rt.cpan.org/Ticket/Display.html?id=89020 >
> > > > > > On Sat Sep 28 17:30:30 2013, g.grigelionis@gmail.com wrote:
> > > > $VERSION = substr q$Revision: 1.05 $, 10; > > > > > > > > yields version number with a trailing space that current versions of > > > > cpan shell warn for > > > > > > > > Version string '1.05 ' contains invalid data; ignoring: ' ' at > > > > /Library/Perl/5.12/ExtUtils/MM_Unix.pm line 2707. > > > > > > > > A better solution is > > > > > > > > $VERSION = (qw$Revision: 1.05 $)[-1];
> > > > > > That code was originally there to support CVS and use its automatically > > > managed Revision number bumping for each commit. Now that the project
> is
> > > hosted at github, I'm going to manually manage it. I'll be making this > > > change: > > > > > > -$VERSION = substr q$Revision: 1.05 $, 10; > > > +$VERSION = '1.06'; > > > +$VERSION = eval $VERSION; > > > > > > BTW, is there a tool to bump $VERSION in all Perl files? I would like
> to
> > > bump to say '1.06_01' while its in development and then bump to '1.06'
> for
> > > the release and then go to '1.06_01'. > > > > > >
> > Great! > > > > Regarding tools, I saw a script once upon a time called "pervers", or > > something like that, but I guess that was before META.yml and
> META.json...
> > Anyway, there are modules like Perl::Version or Version::Next, and some > > hints here: > > http://justatheory.com/computers/programming/perl/increment_version.html
> > Thanks for the links. > > I'm trying to reproduce the error to make sure I get it right and my > testing isn't printing any errors. What command are you using in the cpan > shell? > > Also, what subroutine is line 2707 of MM_Unix.pm line? > > Thanks, > Blair > >
I use CPAN 2.00 which apparently calls parse_version() in MakeMaker; that particular line contains "eval { version->parse( $result ) }". One possibility to see the warning is to use "report" command ("r" in CPAN shell) when Math::Interpolate is installed. Regards, Gintas
  Sun Nov 10 18:55:26 2013 BZAJAC [...] cpan.org - Correspondence added
I uploaded 1.06 to CPAN with this issue fixed. Please try it out and let me know.
  Tue Nov 12 10:17:54 2013 BZAJAC [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Nov 12 10:17:54 2013 BZAJAC [...] cpan.org - Fixed in 1.06 added
  Tue Nov 12 10:17:54 2013 BZAJAC [...] cpan.org - Broken in 1.00 added
  Tue Nov 12 10:17:55 2013 BZAJAC [...] cpan.org - Broken in 1.01 added
  Tue Nov 12 10:17:55 2013 BZAJAC [...] cpan.org - Broken in 1.02 added
  Tue Nov 12 10:17:55 2013 BZAJAC [...] cpan.org - Broken in 1.03 added
  Tue Nov 12 10:17:55 2013 BZAJAC [...] cpan.org - Broken in 1.04 added
  Tue Nov 12 10:17:55 2013 BZAJAC [...] cpan.org - Broken in 1.05 added