Skip Menu |

This queue is for tickets about the Module-Build-Tiny CPAN distribution.

Report information
The Basics
Id: 88990
Status: resolved
Priority: 0/
Queue: Module-Build-Tiny

People
Owner: Nobody in particular
Requestors: vlasenko [...] imath.kiev.ua
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: incorrect check for bindoc - man1 pages are not generated in some perl configurations.
In ALT Linux distribution, perl is built with libdoc undefined, but bindoc defined. The policy is to skip man3 pages and use perldoc for modules but to build man1 pages for end users. Current (0.27) implementation of Module-Build-Tiny checks whether libdoc is defined, but does not check bindoc. As a result, in the ALT Linux distribution man1 pages are generated with Module-Build but never generated with Module-Build-Tiny. the following patch should fix this problem: --- Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-09 12:43:20.000000000 +0300 +++ Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-19 11:08:17.000000000 +0300 @@ -86,8 +86,10 @@ mkpath(catdir(qw/blib arch/), $opt{verbose}); process_xs($_, \%opt) for find(qr/.xs$/, 'lib'); - if ($opt{install_paths}->install_destination('libdoc') && $opt{install_paths}->is_default_installable('libdoc')) { + if ($opt{install_paths}->install_destination('bindoc') && $opt{install_paths}->is_default_installable('bindoc')) { manify($_, catfile('blib', 'bindoc', man1_pagename($_)), $opt{config}->get('man1ext'), \%opt) for keys %scripts; + } + if ($opt{install_paths}->install_destination('libdoc') && $opt{install_paths}->is_default_installable('libdoc')) { manify($_, catfile('blib', 'libdoc', man3_pagename($_)), $opt{config}->get('man3ext'), \%opt) for keys %modules; } },
Subject: Module-Build-Tiny-0.027-alt-bindoc-support.patch
--- Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-09 12:43:20.000000000 +0300 +++ Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-19 11:08:17.000000000 +0300 @@ -86,8 +86,10 @@ mkpath(catdir(qw/blib arch/), $opt{verbose}); process_xs($_, \%opt) for find(qr/.xs$/, 'lib'); - if ($opt{install_paths}->install_destination('libdoc') && $opt{install_paths}->is_default_installable('libdoc')) { + if ($opt{install_paths}->install_destination('bindoc') && $opt{install_paths}->is_default_installable('bindoc')) { manify($_, catfile('blib', 'bindoc', man1_pagename($_)), $opt{config}->get('man1ext'), \%opt) for keys %scripts; + } + if ($opt{install_paths}->install_destination('libdoc') && $opt{install_paths}->is_default_installable('libdoc')) { manify($_, catfile('blib', 'libdoc', man3_pagename($_)), $opt{config}->get('man3ext'), \%opt) for keys %modules; } },
Subject: Re: [rt.cpan.org #88990] incorrect check for bindoc - man1 pages are not generated in some perl configurations.
Date: Fri, 27 Sep 2013 00:19:21 +0200
To: bug-Module-Build-Tiny [...] rt.cpan.org
From: Leon Timmermans <fawaka [...] gmail.com>
On Thu, Sep 26, 2013 at 9:57 PM, Igor Yu. Vlasenko via RT < bug-Module-Build-Tiny@rt.cpan.org> wrote: Show quoted text
> In ALT Linux distribution, perl is built with libdoc undefined, but bindoc > defined. > The policy is to skip man3 pages and use perldoc for modules > but to build man1 pages for end users. > Current (0.27) implementation of Module-Build-Tiny checks whether libdoc > is defined, > but does not check bindoc. As a result, in the ALT Linux distribution man1 > pages are > generated with Module-Build but never generated with Module-Build-Tiny. > > the following patch should fix this problem: > --- Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-09 > 12:43:20.000000000 +0300 > +++ Module-Build-Tiny-0.027/lib/Module/Build/Tiny.pm 2013-09-19 > 11:08:17.000000000 +0300 > @@ -86,8 +86,10 @@ > mkpath(catdir(qw/blib arch/), $opt{verbose}); > process_xs($_, \%opt) for find(qr/.xs$/, 'lib'); > > - if ($opt{install_paths}->install_destination('libdoc') && > $opt{install_paths}->is_default_installable('libdoc')) { > + if ($opt{install_paths}->install_destination('bindoc') && > $opt{install_paths}->is_default_installable('bindoc')) { > manify($_, catfile('blib', 'bindoc', > man1_pagename($_)), $opt{config}->get('man1ext'), \%opt) for keys %scripts; > + } > + if ($opt{install_paths}->install_destination('libdoc') && > $opt{install_paths}->is_default_installable('libdoc')) { > manify($_, catfile('blib', 'libdoc', > man3_pagename($_)), $opt{config}->get('man3ext'), \%opt) for keys %modules; > } > }, > >
Thanks for the bug report and the patch. I've applied it, and will release it in the near future. Leon
On Thu Sep 26 18:19:55 2013, fawaka@gmail.com wrote: Show quoted text
> Thanks for the bug report and the patch. I've applied it, and will > release > it in the near future.
Fix was released in Module::Build::Tiny 0.028. Leon
Птн Окт 04 10:51:54 2013, LEONT писал: Show quoted text
> Fix was released in Module::Build::Tiny 0.028.
Thanks!