Skip Menu |

This queue is for tickets about the Prima CPAN distribution.

Report information
The Basics
Id: 88983
Status: resolved
Priority: 0/
Queue: Prima
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.37
Fixed in: (no value)
Attachments
patch

History Show all quoted text
  Thu Sep 26 09:20:57 2013 ppisar [...] redhat.com - Ticket created
Subject: Installed Prima/Config.pm hard-codes DESTDIR
When installing Prima-1.37 into a non-root DESTDIR to create a distribution package, the installed Prima/Config.pm file stores the DESTDIR directory there which is undesired behavior: $ make pure_install DESTDIR=/tmp/Prima-1.37-dest [...] $ grep Prima-1.37-dest /tmp/Prima-1.37-dest/usr/local/lib64/perl5/Prima/Config.pm incpaths => [ '/tmp/Prima-1.37-dest/usr/local/lib64/perl5/Prima/CORE','/tmp/Prima-1.37-dest/usr/local/lib64/perl5/Prima/CORE/generic','/usr/local/include','/usr/include/freetype2','/usr/include/gtk-2.0','/usr/lib64/gtk-2.0/include','/usr/include/atk-1.0','/usr/include/cairo','/usr/include/gdk-pixbuf-2.0','/usr/include/pango-1.0','/usr/include/glib-2.0','/usr/lib64/glib-2.0/include','/usr/include/pixman-1','/usr/include/libpng15','/usr/include/libdrm','/usr/include/harfbuzz' ], gencls => '/tmp/Prima-1.37-dest/usr/local/bin/gencls', tmlink => '/tmp/Prima-1.37-dest/usr/local/bin/tmlink', libname => '/tmp/Prima-1.37-dest/usr/local/lib64/perl5/auto/Prima/Prima.a', dlname => '/tmp/Prima-1.37-dest/usr/local/lib64/perl5/auto/Prima/Prima.so', inc => '-I/tmp/Prima-1.37-dest/usr/local/lib64/perl5/Prima/CORE -I/tmp/Prima-1.37-dest/usr/local/lib64/perl5/Prima/CORE/generic -I/usr/local/include -I/usr/include/freetype2 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng15 -I/usr/include/libdrm -I/usr/include/harfbuzz',
  Thu Sep 26 13:36:15 2013 KARASIK [...] cpan.org - Correspondence added
Hi, Not that I don't want to help you out, but why do you think this is undesired behaviour? Prima/Config.pm is used in building modules depending on Prima, so from that point of view it looks pretty legit for me. /dk
  Thu Sep 26 13:36:15 2013 The RT System itself - Status changed from 'new' to 'open'
  Mon Sep 30 03:29:54 2013 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #88983] Installed Prima/Config.pm hard-codes DESTDIR
Date: Mon, 30 Sep 2013 09:29:33 +0200
To: KARASIK via RT <bug-Prima [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Thu, Sep 26, 2013 at 01:36:15PM -0400, KARASIK via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=88983 > > > Not that I don't want to help you out, but why do you think this is > undesired behaviour? Prima/Config.pm is used in building modules depending > on Prima, so from that point of view it looks pretty legit for me. >
The problem is the DESTDIR prefix is not the final location. The final run-time location is defined by perl Makefile.PL INSTALLDIRS argument at configuration time. The DESTDIR used by make install is just a temporary prefix to gather all installed files into one directory to be able to pack them into a distribution archive (deb, rpm, tar, etc.). I can see you misuse DESTDIR for running tests. This is not necessary because make test will put blib subdirectories to Perl INC path automatically. -- Petr
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

  Mon Sep 30 04:38:54 2013 KARASIK [...] cpan.org - Correspondence added
Yes now I see the problem. I hope I understand it correctly. I'd like to ask you to try out this patch to Makefile.PL and see if it works for you. Thank you!
Subject: patch
Download patch
application/octet-stream 1.7k

Message body not shown because it is not plain text.

  Mon Sep 30 05:08:59 2013 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #88983] Installed Prima/Config.pm hard-codes DESTDIR
Date: Mon, 30 Sep 2013 11:08:40 +0200
To: KARASIK via RT <bug-Prima [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Mon, Sep 30, 2013 at 04:38:55AM -0400, KARASIK via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=88983 > > > Yes now I see the problem. I hope I understand it correctly. > > I'd like to ask you to try out this patch to Makefile.PL and see if it works > for you. >
I confirm this patch fixes the issue. Thank you for your quick fix. -- Petr
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

  Mon Sep 30 05:37:15 2013 KARASIK [...] cpan.org - Correspondence added
hi Petr, glad it worked! /dk
  Mon Sep 30 05:37:15 2013 KARASIK [...] cpan.org - Status changed from 'open' to 'resolved'