Skip Menu |

This queue is for tickets about the Dist-Zilla-PluginBundle-Author-ETHER CPAN distribution.

Report information
The Basics
Id: 88977
Status: resolved
Priority: 0/
Queue: Dist-Zilla-PluginBundle-Author-ETHER
People
Owner: Nobody in particular
Requestors: haarg [...] haarg.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.027

History Show all quoted text
  Thu Sep 26 07:01:20 2013 haarg [...] haarg.org - Ticket created
Subject: Optional dependencies actually required
Some of the dependencies listed as optional are required for the tests to complete. Dist::Zilla::Plugin::GithubMeta, Dist::Zilla::Plugin::GitHub::Update, and Dist::Zilla::Plugin::AutoMetaResources are all required for the rests. ::GithubMeta will end up being fulfilled by one the the other prerequisites needing it, but it's still listed incorrectly. Additionally, the Dist::Zilla::Plugin::MakeMaker::Fallback and Dist::Zilla::Plugin::ModuleBuildTiny are listed as optional, but are part of the default configuration. This means if another dist uses [@ETHER], running dzil authordeps won't pick up all of the requirements. If Dist::Zilla::Plugin::MakeMaker::Fallback is installed but Dist::Zilla::Plugin::ModuleBuildTiny is not, the tests will fail. Normally, installing ::Fallback would pick up ::ModuleBuildTiny, but it is a test prereqs, so there is no guarantee. And the error comes from the plugin bundle, not from ::Fallback. I think it would be better to just list these all as hard dependencies.
  Thu Sep 26 13:43:46 2013 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #88977] Optional dependencies actually required
Date: Thu, 26 Sep 2013 10:43:28 -0700
To: Graham Knop via RT <bug-Dist-Zilla-PluginBundle-Author-ETHER [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Thu, Sep 26, 2013 at 07:01:20AM -0400, Graham Knop via RT wrote: Show quoted text
> Some of the dependencies listed as optional are required for the tests to complete. Dist::Zilla::Plugin::GithubMeta, Dist::Zilla::Plugin::GitHub::Update, and Dist::Zilla::Plugin::AutoMetaResources are all required for the rests. ::GithubMeta will end up being fulfilled by one the the other prerequisites needing it, but it's still listed incorrectly.
What version are you testing? Can you include the output when you run tests? AutoMetaResources and GithubMeta are only used in one place in tests, and they are guarded with a Test::Requires statement. Show quoted text
> Additionally, the Dist::Zilla::Plugin::MakeMaker::Fallback and Dist::Zilla::Plugin::ModuleBuildTiny are listed as optional, but are part of the default configuration. This means if another dist uses [@ETHER], running dzil authordeps won't pick up all of the requirements.
Yes, but they are injected into prereqs as DevelopRequires. I know this is a bit chicken-and-egg, but installing the develop prereqs of the previous release would get them. Show quoted text
> If Dist::Zilla::Plugin::MakeMaker::Fallback is installed but Dist::Zilla::Plugin::ModuleBuildTiny is not, the tests will fail. Normally, installing ::Fallback would pick up ::ModuleBuildTiny, but it is a test prereqs, so there is no guarantee. And the error comes from the plugin bundle, not from ::Fallback.
Which tests? can you include sample output?
  Thu Sep 26 13:43:46 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 26 23:49:24 2013 ether [...] cpan.org - Correspondence added
required prereqs are now required, and missing optional prereqs don't kill tests. 0.027 released.
  Thu Sep 26 23:49:24 2013 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Oct 23 18:48:34 2014 ether [...] cpan.org - Fixed in 0.027 added