| Subject: | Setting Timeout in Net::Telnet does not work as expected |
1. Typo at line 142:
$connect_args{Timeoout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0);
I think you mean Timeout.
2. Setting Timeout in the connect_args does not set the timeout for all Net::Telnet operations as one might expect, whereas setting it via its accessor does:
$self->telnet->timeout($args->{timeout});
A patchfile is attached.
| Subject: | mozrepl-client.patch |
--- misc/Client.pm 2007-07-04 09:39:48.000000000 +0200
+++ lib/perl5/MozRepl/Client.pm 2013-09-24 18:21:24.000000000 +0200
@@ -93,6 +93,7 @@
Timeout => int($args->{timeout})
}
});
+ $self->telnet->timeout($args->{timeout});
return $self;
}
@@ -139,7 +140,7 @@
$connect_args{Host} = $args->{host} if ($args->{host});
$connect_args{Port} = int($args->{port}) if (defined $args->{port});
- $connect_args{Timeoout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0);
+ $connect_args{Timeout} = int($args->{timeout}) if (defined $args->{timeout} && $args->{timeout} > 0);
unless ($telnet->open(%connect_args)) {
my $message = q|Can't connect to | . sprintf("%s:%d", $connect_args{Host}, $connect_args{Port});