Bug #88785 for Digest-FNV: Digest::FNV calculates a wrong hash with \0 in the data

Wed Sep 18 10:39:46 2013 aardbeiplantje [...] gmail.com - Ticket created

Subject:

Digest::FNV calculates a wrong hash with \0 in the data

When using binary data, it happens a lot that \0 bytes are in the to be hashed data. This breaks the loop in e.g. fnvlib/hash_32.c as the loop checks the *s: while(*s){ ... } This makes for more hash collisions when trying to make a MPH.

Wed Jan 29 11:33:23 2020 nicolas [...] atoomic.org - Correspondence added

On Wed Sep 18 10:39:46 2013, CowboyTim wrote: Show quoted text

> When using binary data, it happens a lot that \0 bytes are in the to > be hashed data. This breaks the loop in e.g. fnvlib/hash_32.c as the > loop checks the *s: > > while(*s){ > ... > } > > This makes for more hash collisions when trying to make a MPH.

seems like the original implementation provide some helpers to take into account the length look at the fnv_32_buf and fnv_64_buf these are the functions we want to use... http://www.isthe.com/chongo/src/fnv/hash_32.c

Wed Jan 29 11:33:24 2020 The RT System itself - Status changed from 'new' to 'open'