| Subject: | Some tests are always passing |
Some of the tests in Net::SAML2 are written wrong. The first argument to C<ok()> is a regular expression always evaluating to true.
Most tests would probably work if you used C<like> instead of C<ok> and swap the order of arguments.
$ egrep 'ok.*qr' *.t
04-response.t:ok(qr/verified/, $subject);
07-logout-request.t:ok(qr/ID=".+"/, $xml);
07-logout-request.t:ok(qr/IssueInstant=".+"/, $xml);
07-logout-request.t:ok(qr/persistent/, $xml);
08-logout-response.t:ok(qr/ID=".+"/, $xml);
08-logout-response.t:ok(qr/IssueInstant=".+"/, $xml);
10-artifact-resolve.t:ok(qr/ID=".+"/, $xml);
10-artifact-resolve.t:ok(qr/IssueInstant=".+"/, $xml);