Bug #88641 for Class-Method-Modifiers: 5.6 compatibility promptly lost in dzil conversion

Fri Sep 13 00:58:49 2013 ribasushi [...] leporine.io - Ticket created

Subject:

5.6 compatibility promptly lost in dzil conversion

Please consider repackaging CMM using a more conventional dzil installer method (say EUMM), as opposed to Moduke::Build::Tiny. MBT requires 5.8 to function (due to over-relience on proper IO layers) Cheers

Fri Sep 13 13:09:34 2013 ether [...] cpan.org - Correspondence added

On 2013-09-12 21:58:49, RIBASUSHI wrote: Show quoted text

> Please consider repackaging CMM using a more conventional dzil > installer method (say EUMM), as opposed to Moduke::Build::Tiny. MBT > requires 5.8 to function (due to over-relience on proper IO layers) > > Cheers

My feeling is that we've gained more by avoiding EUMM and supporting leont's advances in this area, than we've lost by abandoning 5.6. I've heard of exactly *zero* users still on 5.6 that are upgrading modules from the CPAN. I'll leave this open however as it's not my unilateral decision.

Fri Sep 13 13:09:35 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 13 13:09:42 2013 ether [...] cpan.org - Severity Wishlist added

Fri Sep 13 13:33:56 2013 ether [...] cpan.org - Correspondence added

it's an easy enough change, so I fixed CMM so it uses EUMM once more.

Fri Sep 13 13:33:57 2013 ether [...] cpan.org - Status changed from 'open' to 'patched'

Tue Sep 17 02:03:26 2013 ribasushi [...] leporine.io - Correspondence added

On Fri Sep 13 13:33:56 2013, ETHER wrote: Show quoted text

> it's an easy enough change, so I fixed CMM so it uses EUMM once more.

I was aware the change was a one-liner, which is why I didn't provide a patch. If there are no other immediate pending improvements, could you please cut a new PAUSE upload so that I can revert https://github.com/dbsrgits/dbix-class/commit/72cd4007 and as a result start smoking[1] the lvalue changes (though in fairness preliminary testing did not reveal issues) [1] I say smoking because the travis-ci setup of DBIC at times goes to far greater lengths than what is commonly done on cpantesters. Maybe I should just enable a reporter... ;)

Tue Sep 17 15:44:21 2013 ether [...] cpan.org - Correspondence added

2.06 is released using EUMM.

Tue Sep 17 15:44:22 2013 ether [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue Oct 08 04:16:02 2013 ribasushi [...] leporine.io - Correspondence added

Just reopening this, so I get an email when the fixed version ships. If you need help with tarball testing on perl v.<old> - let me know.

Tue Oct 08 04:16:03 2013 ribasushi [...] leporine.io - Status changed from 'resolved' to 'open'

Fri Oct 11 05:32:47 2013 ribasushi [...] leporine.io - Correspondence added

2.08 is close but no cigar. It has two remaining issues with its deps, I am taking care of one of them, but the other is for you: you use the `if` module in all tests. It is not core until 5.6.2. Installing it on 5.6.1 goes through without a hitch, so it's a mere META ommission. Cheers! P.S. this is a minor issue, and can wait unti the release with mst's docpatches or whatnot P.P.S If you are wondering what the second issue is - MBT does not install on 5.6, but that's a patch-fest for another day, and not really your problem.

Fri Oct 11 11:50:31 2013 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Oct 11 11:50:32 2013 ether [...] cpan.org - Fixed in 2.08 added

Fri Oct 11 11:51:12 2013 ether [...] cpan.org - Correspondence added

oops sorry didn't see your mail until just after I closed this.

Fri Oct 11 11:51:13 2013 ether [...] cpan.org - Status changed from 'resolved' to 'open'

Fri Oct 11 11:55:01 2013 ether [...] cpan.org - Correspondence added

On 2013-10-11 02:32:47, RIBASUSHI wrote: Show quoted text

> you use the `if` module in all tests. It is not core until 5.6.2. > Installing it on 5.6.1 goes through without a hitch, so it's a mere > META ommission.

Is your issue that it wasn't in core in 5.6.0, or...? because it is listed in META.* as a test requirement. Can you link to the MBT issue here?

Fri Oct 11 12:45:30 2013 ribasushi [...] leporine.io - Correspondence added

On Fri Oct 11 11:55:01 2013, ETHER wrote: Show quoted text

> On 2013-10-11 02:32:47, RIBASUSHI wrote: >

> > you use the `if` module in all tests. It is not core until 5.6.2. > > Installing it on 5.6.1 goes through without a hitch, so it's a mere > > META ommission.

> > Is your issue that it wasn't in core in 5.6.0, or...? because it is > listed in META.* as a test requirement.

I am an idiot - I honestly missed that. With that the only issue remain MBT, so nothing else left on the 5.6 compat front as far as this dist is concerned. Show quoted text

> Can you link to the MBT issue here?

I haven't filed any - it's a general "depchain does not work on 5.6", and I am planning to look into that some time next week.

Fri Oct 11 12:45:30 2013 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'