Skip Menu |

This queue is for tickets about the MojoX-Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 88633
Status: resolved
Priority: 0/
Queue: MojoX-Log-Log4perl

People
Owner: Nobody in particular
Requestors: PLICEASE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.06
Fixed in: (no value)



Subject: fails to install on Win32
The regex the regex in t/02-justworks.t is failing on Windows because it isn't correctly matching against windows line endings. I am attaching a change to the test which makes it work for me. Please consider this for inclusion in the next version, or if you have a better fix, I'd be happy to help test it for you.
Subject: mojox-log4perl-winfix.diff
diff --git a/t/02-justworks.t b/t/02-justworks.t index 2d3a932..a25827a 100644 --- a/t/02-justworks.t +++ b/t/02-justworks.t @@ -30,7 +30,7 @@ my $content = Mojo::Asset::File->new(path => $path)->slurp; like( $content, - qr/^\[DEBUG\] main:21 - Just works\.\n\[DEBUG\] main:22 - told ya!$/s, + qr/^\[DEBUG\] main:21 - Just works\.\015?\n\[DEBUG\] main:22 - told ya!\015?$/s, 'right content' );
On Thu Sep 12 15:13:39 2013, PLICEASE wrote: Show quoted text
> The regex the regex in t/02-justworks.t is failing on Windows because > it isn't correctly matching against windows line endings. I am > attaching a change to the test which makes it work for me. Please > consider this for inclusion in the next version, or if you have a > better fix, I'd be happy to help test it for you.
Hey! Thanks for using MojoX::Log::Log4perl, and for reporting this issue. I've (hopefully) fixed the issue by splitting that test into two, one for each message. I wasn't able to use your patch as it broke other operating systems, but thanks for sending it anyway: it was important to quickly understand why it was failing on Win32. Version 0.07 was already shipped and should reach your local CPAN mirror in the next few hours. Please let me know if it's still failing, ok? Cheers! garu