Bug #88537 for Prophet: tests fail even when all "recommended" dependencies are installed

Mon Sep 09 07:51:33 2013 lxp [...] cpan.org - Ticket created

Subject:

tests fail even when all "recommended" dependencies are installed

Prophet is failing to install for me using cpanminus. The verbose output of cpanminus does not give anything obvious away. Many is() tests are simply failing with empty "got" values and quite a few failures are being reported from Config::GitLike: Can't use an undefined value as a HASH reference at .../Config/GitLike.pm line 429. Use of uninitialized value in concatenation (.) or string at .../Config/GitLike.pm line 124. My full cpanminus output is available here: https://gist.github.com/Lx/6494577

Mon Sep 09 08:05:52 2013 FLH [...] cpan.org - Ticket #88538: Ticket created

Subject:

Newer Config::GitLike breaks sd

Dear authors, I've been playing with sd 0.75 (on Debian testing), which works fine with Config::GitLike version 1.08. Yet, Debian upgraded to Config::GitLike 1.10, and now almost all sd commands break with the following error: Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/Config/GitLike.pm line 135. Downgrading Config::GitLike to 1.08 solves the issue. Is there any way to fix sd with the more recent version of Config::GitLike? Thanks.

Mon Sep 09 08:45:06 2013 lxp [...] cpan.org - Correspondence added

[rt.cpan.org #88538] suggests that the Config::GitLike errors are caused by an API change in Config::GitLike v1.09 or newer.

Mon Sep 09 08:45:07 2013 lxp [...] cpan.org - Reference to ticket #88537 added

Mon Sep 09 08:45:07 2013 lxp [...] cpan.org - Ticket #88538: Reference by ticket #88537 added

Tue Sep 10 04:11:12 2013 ioanr [...] cpan.org - Reference by ticket #88536 added

Tue Sep 10 04:33:02 2013 ioanr [...] cpan.org - Reference to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720794 added

Tue Sep 10 04:40:34 2013 ioanr [...] cpan.org - Ticket #88538: Merged into ticket #88537

Tue Sep 10 04:40:34 2013 ioanr [...] cpan.org - Merged into ticket #88537

Tue Sep 10 04:41:22 2013 ioanr [...] cpan.org - Taken

Tue Sep 10 04:50:26 2013 ioanr [...] cpan.org - Correspondence added

Some of the bugs in the gist were in the test suite, and are now fixed in git master.

So far, I'm unable to reproduce the Config::GitLike errors. I have 1.12 installed.

Tue Sep 10 04:50:27 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 10 05:10:08 2013 FLH [...] cpan.org - Correspondence added

Le Mar 10 Sep 2013 04:50:26, IOANR a écrit : Show quoted text

> So far, I'm unable to reproduce the Config::GitLike errors. I have > 1.12 installed.

I've just installed Config::GitLike 1.12 from CPAN, and I still get the same error with sd 0.75: $ export SD_REPO=~/sd_test $ sd init Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.14.2/Config/GitLike.pm line 135. I'll try to investigate what causes this error on my computer in the next few days.

Thu Sep 12 09:44:36 2013 lxp [...] cpan.org - Correspondence added

On Tue Sep 10 18:50:26 2013, IOANR wrote: Show quoted text

> So far, I'm unable to reproduce the Config::GitLike errors. I have > 1.12 installed.

In case this helps, one of the warnings I mentioned earlier: Show quoted text

> Can't use an undefined value as a HASH reference at > .../Config/GitLike.pm line 429.

references this line of Config::GitLike v1.12: if ( !defined $self->origins->{$key} || ... ) { suggesting that $self->origins is undefined at the time of the call. However, the definition for the "origins" attribute is meant to prohibit instantiation with an undefined "origins" value: use Moo; use MooX::Types::MooseLike::Base qw( ... HashRef ... ); ... has 'origins' => ( is => 'rw', isa => HashRef, default => sub { +{} }, ); suggesting that Moo itself could be the problem. I had Moo v1.003 installed when I experienced these warnings, but upgrading to Moo v1.003001 has not fixed the problem.

Thu Sep 12 09:52:14 2013 lxp [...] cpan.org - Correspondence added

On Tue Sep 10 19:10:08 2013, FLH wrote: Show quoted text

> Use of uninitialized value in concatenation (.) or string at > /usr/local/share/perl/5.14.2/Config/GitLike.pm line 135.

This warning and another one referencing line 124 indicate that the "confname" attribute of the GitLike object is undefined. As per the "origins" attribute (see my previous message), this is in breach of the attribute's definition: has 'confname' => ( is => 'rw', required => 1, isa => Str, ); This continues to suggest a Moo problem. Another possibility is that something is directly modifying/clearing the underlying hash used by Moo for holding the object's state.

Thu Sep 12 10:04:04 2013 lxp [...] cpan.org - Correspondence added

On Thu Sep 12 23:52:14 2013, LXP wrote: Show quoted text

> This continues to suggest a Moo problem. > > Another possibility is that something is directly modifying/clearing > the underlying hash used by Moo for holding the object's state.

I also note that Prophet::Config (which "extends" Config::GitLike) uses Any::Moose while Config::GitLike itself uses Moo. I wonder if it's possible that Any::Moose is somehow interfering. All of these modules on my system are at their latest versions: $ pmvers Any::Moose Moo Config::GitLike Any::Moose: 0.21 Moo: 1.003001 Config::GitLike: 1.12

Thu Sep 12 10:08:37 2013 lxp [...] cpan.org - Correspondence added

On Fri Sep 13 00:04:04 2013, LXP wrote: Show quoted text

> I wonder if it's possible that Any::Moose is somehow interfering.

Apparently Any::Moose is now deprecated in favour of Moo. While a quick glance at the Any::Moose code suggests that it shouldn't be interfering with Moo, I wonder whether simply replacing all of the "Any::Moose" references with "Moo" will fix things.

Mon Sep 16 17:45:56 2013 ioanr [...] cpan.org - Correspondence added

Thanks for all you've done so far. I'll see if I can reproduce the failures sometime in the next few days.

Unfortunately, replacing Any::Moose with Moo alone would break things more because of the use of Moose types, and differences in how Moo handles type coercion.

I'm in the middle of a refactor (AnyMoose_to_Moo branch on gitorious), though I'm only getting a day or two a month to work on it.

Wed Mar 12 14:18:50 2014 ioanr [...] cpan.org - Correspondence added

I've finally got the time to look at this again.

The problem is caused somehow by Mouse, which I must not have had installed during my previous attempts to reproduce.

As a workaround, setting ANY_MOOSE=Moose gets the test suite passing.

Wed Mar 12 19:42:00 2014 lxp [...] cpan.org - Reference by ticket #93809 added

Wed Mar 12 19:43:45 2014 lxp [...] cpan.org - Reference by ticket #93809 added

Wed Mar 12 19:50:01 2014 lxp [...] cpan.org - Reference by ticket #93811 added