Bug #88365 for Module-CPANTS-Analyse: YAML/JSON tests are not failing when improperly encoded characters are seen

Mon Sep 02 20:20:55 2013 ether [...] cpan.org - Ticket created

Subject:

YAML/JSON tests are not failing when improperly encoded characters are seen

When an improperly encoded character appears in a META.* file, the validation tests should fail. e.g. in the MooseX-Storage 0.40 release, I see: xt/release/kwalitee.t ............. utf8 "\xE5" does not map to Unicode at /Users/ether/.perlbrew/libs/19.3@std/lib/perl5/Module/CPANTS/Kwalitee/MetaYML.pm line 31, <$fh> chunk 1. xt/release/kwalitee.t ............. ok This test should be failing, because the META.yml file in this release contains bad encoding (due to a Dist::Zilla problem, we think) -- especially since the CPANTS site is showing lots of problems parsing the file (see RT#88215).

Mon Sep 02 20:26:31 2013 ether [...] cpan.org - Reference to ticket #88215 added

Thu Sep 05 03:53:51 2013 ishigaki [...] cpan.org - Correspondence added

On Tue Sep 03 09:20:55 2013, ETHER wrote: Show quoted text

> When an improperly encoded character appears in a META.* file, the > validation tests should fail. > > e.g. in the MooseX-Storage 0.40 release, I see: > > xt/release/kwalitee.t ............. utf8 "\xE5" does not map to > Unicode at > /Users/ether/.perlbrew/libs/19.3@std/lib/perl5/Module/CPANTS/Kwalitee/MetaYML.pm > line 31, <$fh> chunk 1. > xt/release/kwalitee.t ............. ok > > This test should be failing, because the META.yml file in this release > contains bad encoding (due to a Dist::Zilla problem, we think) -- > especially since the CPANTS site is showing lots of problems parsing > the file (see RT#88215).

Fixed in the repository. Thanks. https://github.com/cpants/Module-CPANTS-Analyse/commit/37c38e843e2f55fa4504f2378a4cdb955460a589

Thu Sep 05 03:53:52 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 05 03:53:52 2013 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Thu Sep 05 09:18:31 2013 ishigaki [...] cpan.org - Correspondence added

Closed as 0.91 was released. Thanks. On Thu Sep 05 16:53:51 2013, ISHIGAKI wrote: Show quoted text

> On Tue Sep 03 09:20:55 2013, ETHER wrote:

> > When an improperly encoded character appears in a META.* file, the > > validation tests should fail. > > > > e.g. in the MooseX-Storage 0.40 release, I see: > > > > xt/release/kwalitee.t ............. utf8 "\xE5" does not map to > > Unicode at > > /Users/ether/.perlbrew/libs/19.3@std/lib/perl5/Module/CPANTS/Kwalitee/MetaYML.pm > > line 31, <$fh> chunk 1. > > xt/release/kwalitee.t ............. ok > > > > This test should be failing, because the META.yml file in this > > release > > contains bad encoding (due to a Dist::Zilla problem, we think) -- > > especially since the CPANTS site is showing lots of problems parsing > > the file (see RT#88215).

> > > Fixed in the repository. Thanks. > > https://github.com/cpants/Module-CPANTS- > Analyse/commit/37c38e843e2f55fa4504f2378a4cdb955460a589

Thu Sep 05 09:18:32 2013 ishigaki [...] cpan.org - Status changed from 'patched' to 'resolved'