Bug #88279 for Dist-Zilla-Plugin-Test-Compile: Drop Test::More 0.88 dependency

Thu Aug 29 17:01:22 2013 dagolden [...] cpan.org - Ticket created

Subject:

Drop Test::More 0.88 dependency

Is there any reason why Test::More 0.88 is needed? I'd like to see the generated compile test work with v5.8.1 core modules so I can use it OnlyCorePrereqs. Right now, I can't for older Perls. (Side note: kudos for eliminating Capture::Tiny already.)

Thu Aug 29 18:49:19 2013 ether [...] cpan.org - Correspondence added

On 2013-08-29 14:01:22, DAGOLDEN wrote: Show quoted text

> Is there any reason why Test::More 0.88 is needed? > > I'd like to see the generated compile test work with v5.8.1 core > modules so I can use it OnlyCorePrereqs. Right now, I can't for older > Perls. > > (Side note: kudos for eliminating Capture::Tiny already.)

v0.88 is when done_testing was added. (PS. if you use the bail_out_on_fail feature -- disabled by default -- you get a dependency on 0.94, for BAIL_OUT.) I can look at removing that and adding a plan instead, although there may be some fun cases where extra tests get added (e.g. Test::*Warning*). I'm ripping out Test::Script right now; I'll look at this next to see if I'm just being overly paranoid.

Thu Aug 29 18:49:19 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Aug 29 18:50:43 2013 ether [...] cpan.org - Correspondence added

Show quoted text

> I can look at removing that and adding a plan instead, although there > may be some fun cases where extra tests get added (e.g. > Test::*Warning*).

Of course, even if this is a problem for some dists, there can be an option like "use_plan" which switches between test counts and done_testing. so yes, this is doable!

Thu Aug 29 21:29:59 2013 ether [...] cpan.org - Correspondence added

v2.023 has shipped, with test counts rather than done_testing.

Thu Aug 29 21:29:59 2013 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Aug 29 21:30:00 2013 ether [...] cpan.org - Taken

Thu Oct 23 18:57:19 2014 ether [...] cpan.org - Fixed in 2.023 added