Bug #88254 for XML-LibXML: C14N does not allow c14n v1.1

Thu Aug 29 08:45:22 2013 u.wisser [...] publisher.de - Ticket created

Subject:

C14N does not allow c14n v1.1

libxml2 does export three modes for c14n Enum xmlC14NMode { XML_C14N_1_0 = 0 : Origianal C14N 1.0 spec XML_C14N_EXCLUSIVE_1_0 = 1 : Exclusive C14N 1.0 spec XML_C14N_1_1 = 2 : C14N 1.1 spec } XML::LibXML does only allow two of these.

Fri Aug 30 05:44:39 2013 SHLOMIF [...] cpan.org - Correspondence added

On Thu Aug 29 08:45:22 2013, WISSER wrote: Show quoted text

> libxml2 does export three modes for c14n > > Enum xmlC14NMode { > XML_C14N_1_0 = 0 : Origianal C14N 1.0 spec > XML_C14N_EXCLUSIVE_1_0 = 1 : Exclusive C14N 1.0 spec > XML_C14N_1_1 = 2 : C14N 1.1 spec > } > > XML::LibXML does only allow two of these.

Hi, thanks for the report. Do you know if the support for that in libxml2 was added only in relatively recent versions (which will complicate adding support for this in XML::LibXML)? And naturally - patches will be welcome. Regards, -- Shlomi Fish

Fri Aug 30 05:44:39 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 30 16:31:54 2013 ulrich [...] wisser.se - Correspondence added

Subject:	Re: [rt.cpan.org #88254] C14N does not allow c14n v1.1
Date:	Fri, 30 Aug 2013 22:31:40 +0200
To:	bug-XML-LibXML [...] rt.cpan.org
From:	Ulrich Wisser <ulrich [...] wisser.se>

I found the commit https://git.gnome.org/browse/libxml2/commit/?id=838682478cf89ddcbda294d9557c72813135fc7a Support for the c14n v1.1 was added on 2009-07-09. Although not a patch, I would suggest copying the toStringC14N method. Something like sub toStringC14N11 { my ($self, $comments, $xpath, $xpc) = @_; return $self->_toStringC14N( $comments || 0, (defined $xpath ? $xpath : undef), 2, undef, (defined $xpc ? $xpc : undef) ); } The nethod name is not really optimal, but that's all my creative side could come up with. :) /Ulrich 2013/8/30 Shlomi Fish via RT <bug-XML-LibXML@rt.cpan.org> Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=88254 > > > On Thu Aug 29 08:45:22 2013, WISSER wrote:

> > libxml2 does export three modes for c14n > > > > Enum xmlC14NMode { > > XML_C14N_1_0 = 0 : Origianal C14N 1.0 spec > > XML_C14N_EXCLUSIVE_1_0 = 1 : Exclusive C14N 1.0 spec > > XML_C14N_1_1 = 2 : C14N 1.1 spec > > } > > > > XML::LibXML does only allow two of these.

> > Hi, > > thanks for the report. Do you know if the support for that in libxml2 was > added only in relatively recent versions (which will complicate adding > support for this in XML::LibXML)? And naturally - patches will be welcome. > > Regards, > > -- Shlomi Fish >

Sat Sep 07 10:19:30 2013 SHLOMIF [...] cpan.org - Correspondence added

Hi Ulrich, Thanks! I applied a modified version of your changes in revision 1317:2488902c7504df3f76c0ba291d5b20edbf8b663b and they will be part of the next XML-LibXML release (I'm still waiting on a pull request). In the meanwhile, I'm going to close this bug report, but you can reopen it. Regards, -- Shlomi Fish On Fri Aug 30 16:31:54 2013, ulrich@wisser.se wrote: Show quoted text

> I found the commit > > https://git.gnome.org/browse/libxml2/commit/?id=838682478cf89ddcbda294d9557c72813135fc7a > > Support for the c14n v1.1 was added on 2009-07-09. > > Although not a patch, I would suggest copying the toStringC14N method. > Something like > > sub toStringC14N11 { > my ($self, $comments, $xpath, $xpc) = @_; > return $self->_toStringC14N( $comments || 0, > (defined $xpath ? $xpath : undef), > 2, > undef, > (defined $xpc ? $xpc : undef) > ); > } > > The nethod name is not really optimal, but that's all my creative side > could come up with. :) > > /Ulrich > > > 2013/8/30 Shlomi Fish via RT <bug-XML-LibXML@rt.cpan.org> >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=88254 > > > > > On Thu Aug 29 08:45:22 2013, WISSER wrote:

> > > libxml2 does export three modes for c14n > > > > > > Enum xmlC14NMode { > > > XML_C14N_1_0 = 0 : Origianal C14N 1.0 spec > > > XML_C14N_EXCLUSIVE_1_0 = 1 : Exclusive C14N 1.0 spec > > > XML_C14N_1_1 = 2 : C14N 1.1 spec > > > } > > > > > > XML::LibXML does only allow two of these.

> > > > Hi, > > > > thanks for the report. Do you know if the support for that in libxml2 > > was > > added only in relatively recent versions (which will complicate > > adding > > support for this in XML::LibXML)? And naturally - patches will be > > welcome. > > > > Regards, > > > > -- Shlomi Fish > >

Sat Sep 07 10:19:32 2013 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'