Bug #88210 for Tk: Bleadperl v5.19.0-57-g6d5abc6 breaks Tk-804.031

Wed Aug 28 10:55:29 2013 ANDK [...] cpan.org - Ticket created

Subject:

Bleadperl v5.19.0-57-g6d5abc6 breaks Tk-804.031

As per subject. Uncovered by bisect. See http://perl5.git.perl.org/perl.git/commitdiff/6d5abc6

Thu Aug 29 01:54:23 2013 ANDK [...] cpan.org - Correspondence added

I forgot to add diagnostics. Sample compilation failure: http://www.cpantesters.org/cpan/report/7fb8d212-c552-11e2-9713-373e989cd64d The gist of it is: Xlib.xs: In function ‘XS_DisplayPtr_XListFonts’: Xlib.xs:230:75: error: ‘bool’ undeclared (first use in this function) EXTEND(sp, count); ^ Xlib.xs:230:75: note: each undeclared identifier is reported only once for each function it appears in Xlib.xs:230:80: error: expected ‘:’ before numeric constant EXTEND(sp, count); ^ Xlib.xs: In function ‘XS_DisplayPtr_XQueryTree’: Xlib.xs:321:76: error: ‘bool’ undeclared (first use in this function) XPUSHs(sv); ^ Xlib.xs:321:81: error: expected ‘:’ before numeric constant XPUSHs(sv); ^ make[1]: *** [Xlib.o] Error 1

Thu Aug 29 02:45:18 2013 SREZIC [...] cpan.org - Correspondence added

On 2013-08-29 01:54:23, ANDK wrote: Show quoted text

> I forgot to add diagnostics. Sample compilation failure: > > http://www.cpantesters.org/cpan/report/7fb8d212-c552-11e2-9713- > 373e989cd64d > > The gist of it is: > > Xlib.xs: In function ‘XS_DisplayPtr_XListFonts’: > Xlib.xs:230:75: error: ‘bool’ undeclared (first use in this function) > EXTEND(sp, count); > ^ > Xlib.xs:230:75: note: each undeclared identifier is reported only once > for each function it appears in > Xlib.xs:230:80: error: expected ‘:’ before numeric constant > EXTEND(sp, count); > ^ > Xlib.xs: In function ‘XS_DisplayPtr_XQueryTree’: > Xlib.xs:321:76: error: ‘bool’ undeclared (first use in this function) > XPUSHs(sv); > ^ > Xlib.xs:321:81: error: expected ‘:’ before numeric constant > XPUSHs(sv); > ^ > make[1]: *** [Xlib.o] Error 1

Can you check if the attached patch works for you? Regards, Slaven

Subject:

fix-bool.patch

diff --git c/pTk/Lang.h w/pTk/Lang.h index 4598291..b09cede 100644 --- c/pTk/Lang.h +++ w/pTk/Lang.h @@ -4,10 +4,6 @@ #define STATIC_BUILD -#ifdef bool -#undef bool -#endif - #include "tkConfig.h" #define TCL_NO_DEPRECATED

Thu Aug 29 02:45:18 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Aug 29 02:53:38 2013 SREZIC [...] cpan.org - Correspondence added

On 2013-08-28 10:55:29, ANDK wrote: Show quoted text

> As per subject. Uncovered by bisect. > > See http://perl5.git.perl.org/perl.git/commitdiff/6d5abc6

Link to related rt.perl.org ticket: https://rt.perl.org/rt3//Public/Bug/Display.html?id=118189

Thu Aug 29 03:25:42 2013 ANDK [...] cpan.org - Correspondence added

tested with v5.19.0-57-g6d5abc6 and your patch: All tests successful.

Sat Nov 16 08:02:29 2013 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'

Sun Nov 17 06:49:51 2013 SREZIC [...] cpan.org - Correspondence added

On 2013-08-29 03:25:42, ANDK wrote: Show quoted text

> tested with v5.19.0-57-g6d5abc6 and your patch: > > All tests successful.

Tk 804.031_500 is out.

Sun Nov 17 06:49:53 2013 SREZIC [...] cpan.org - Status changed from 'patched' to 'resolved'