Tue Aug 27 10:57:56 2013zefram [...] fysh.org - Ticket created
Subject:
wrong test for magicalness
Date:
Tue, 27 Aug 2013 15:57:35 +0100
To:
bug-Devel-Size [...] rt.cpan.org
From:
Zefram <zefram [...] fysh.org>
Devel::Size looks at the SvMAGIC pointer for any SV that's SVt_PVMG
or above. This is incorrect. It is actually necessary (and sufficient)
to check the SvMAGICAL flag. Attached patch fixes.
-zefram
Message body is not shown because sender requested not to inline it.
Sat Dec 14 20:03:50 2013d.thomas [...] its.uq.edu.au - Correspondence added
From:
d.thomas [...] its.uq.edu.au
building under 5.19.6 results in test FAILure
which does not happen on 5.18.2-RC2
t/magic.t ..... 1/18
# Failed test 'the magic object is counted'
# at t/magic.t line 55.
# '1248'
# >
# '1256'
# Looks like you failed 1 test of 18.
t/magic.t ..... Dubious, test returned 1 (wstat 256, 0x100)
this is on RHEL6. Devel-Size-0.79
On Tue Aug 27 10:57:56 2013, zefram@fysh.org wrote:
Show quoted text
> Attached patch fixes.
on the off chance the patch might help,
I applied it but got the same error condition
Sat Dec 14 20:03:50 2013The RT System itself - Status changed from 'new' to 'open'
Sun Dec 15 05:55:32 2013zefram [...] fysh.org - Correspondence added
Subject:
Re: [rt.cpan.org #88180] wrong test for magicalness
d.thomas@its.uq.edu.au via RT wrote:
Show quoted text
>t/magic.t ..... 1/18
># Failed test 'the magic object is counted'
># at t/magic.t line 55.
># '1248'
># >
># '1256'
That's [rt.cpan.org #88182]. Patch available on that ticket.
-zefram
Sat Feb 28 09:29:39 2015nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Correspondence added
On Tue Aug 27 10:57:56 2013, zefram@fysh.org wrote:
Show quoted text
> Devel::Size looks at the SvMAGIC pointer for any SV that's SVt_PVMG
> or above. This is incorrect. It is actually necessary (and sufficient)
> to check the SvMAGICAL flag. Attached patch fixes.
Thanks applied.
Along with your other patch, uploaded to CPAN as 0.79_50.
I'm aware that the uploaded version still fails some other tests on some versions.
Sat Feb 28 09:29:40 2015nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Status changed from 'open' to 'patched'
Wed Apr 17 06:32:05 2019nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Status changed from 'patched' to 'resolved'
RT for rt.cpan.org