Skip Menu |

This queue is for tickets about the Test-NoTabs CPAN distribution.

Report information
The Basics
Id: 88042
Status: new
Priority: 0/
Queue: Test-NoTabs
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Aug 22 20:32:01 2013 ether [...] cpan.org - Ticket created
Subject: looking for files in the wrong dir(s)
This module assumes that it is running out of something like t/no-tabs.t. When it is instead run out of xt/release/no-tabs.t, it fails to find any .pm files, because it only looks one directory up. It should actually be looking relative to the CWD, not where the test is located. I can fix this in Dist::Zilla::Plugin::NoTabsTests (by doing a file-find there and passing the files one at a time to notabs_ok(), but it would be better to fix it here, once and for all.
  Thu Sep 19 00:06:45 2013 ether [...] cpan.org - Correspondence added
BTW the new Dist::Zilla::Plugin::Test::NoTabs works around this issue, by passing in an explicit list of files to notabs_ok(). I noticed Test::EOL had been fixed with this issue last year, so the same fixed _find_files logic can be lifted from there.
  Thu Jan 29 23:15:20 2015 ether [...] cpan.org - Correspondence added
On 2013-09-18 21:06:45, ETHER wrote: Show quoted text
> BTW the new Dist::Zilla::Plugin::Test::NoTabs works around this issue, > by passing in an explicit list of files to notabs_ok(). > > I noticed Test::EOL had been fixed with this issue last year, so the > same fixed _find_files logic can be lifted from there.
The relevant commit is this one: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits/Test-EOL.git;a=commitdiff;h=856d7baf059e2f87941216e3067dbb1deaa955c3
  Fri Jul 03 15:17:18 2015 ether [...] cpan.org - Correspondence added
On 2015-01-29 20:15:20, ETHER wrote: Show quoted text
> On 2013-09-18 21:06:45, ETHER wrote:
> > BTW the new Dist::Zilla::Plugin::Test::NoTabs works around this > > issue, > > by passing in an explicit list of files to notabs_ok(). > > > > I noticed Test::EOL had been fixed with this issue last year, so the > > same fixed _find_files logic can be lifted from there.
> > The relevant commit is this one: > > http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits/Test- > EOL.git;a=commitdiff;h=856d7baf059e2f87941216e3067dbb1deaa955c3
@t0m if you want to bonk me with a comaint bit, I'll fix this up, and the other tickets in the RT queue? :)