Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git CPAN distribution.

Report information
The Basics
Id: 88024
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-Git
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.014
Fixed in: (no value)
Attachments
signature.asc

History Show all quoted text
  Thu Aug 22 06:31:11 2013 KENTNL [...] cpan.org - Ticket created
Subject: Contents of Submodules not added
There doesn't appear to be an obvious way to include submodules in a dist.

`git ls-files` does not traverse submodules by default.

For instance, on my dumpphases dist, git ls-files does this:

.gitignore
.gitmodules
.perltidyrc
Changes
README.mkdn
dist.ini
layout/self_structure.dot
layout/self_structure.png
lib/Dist/Zilla/App/Command/dumpphases.pm
lib/Dist/Zilla/dumpphases/Role/Theme.pm
lib/Dist/Zilla/dumpphases/Role/Theme/SimpleColor.pm
lib/Dist/Zilla/dumpphases/Theme/basic/blue.pm
lib/Dist/Zilla/dumpphases/Theme/basic/green.pm
lib/Dist/Zilla/dumpphases/Theme/basic/plain.pm
lib/Dist/Zilla/dumpphases/Theme/basic/red.pm
media 
perlcritic.rc
weaver.ini

here, 'media' is a directory, and is not a symlink, and contains real files.

but the only way to traverse their contents is via:

git submodule foreach git ls-files

Entering 'media'
example_01.png
theme_basic_blue.png
theme_basic_green.png
theme_basic_plain.png
theme_basic_red.png




  Thu Aug 22 10:14:38 2013 cjm [...] cpan.org - Correspondence added
Well, you could add an instance of Git::GatherDir for each submodule. I'd accept a patch to gather submodules automatically, although we might want it to be off by default to avoid breaking people who are using the multiple-instance workaround.
  Thu Aug 22 10:14:39 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Aug 22 15:47:56 2013 rjbs [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #88024] Contents of Submodules not added
Date: Thu, 22 Aug 2013 15:47:40 -0400
To: Kent Fredric via RT <bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org>
From: Ricardo Signes <rjbs [...] cpan.org>
* Kent Fredric via RT <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> [2013-08-22T06:31:12] Show quoted text
> There doesn't appear to be an obvious way to include submodules in a dist.
Please forgive this "what you want is wrong" reply, because I generally despise those. That said: have you considered using subtrees instead of submodules? They are a much saner replacement. -- rjbs
Download signature.asc
application/pgp-signature 490b

Message body not shown because it is not plain text.