Skip Menu |

This queue is for tickets about the DBIx-Class-DigestColumns CPAN distribution.

Report information
The Basics
Id: 87920
Status: rejected
Priority: 0/
Queue: DBIx-Class-DigestColumns

People
Owner: Nobody in particular
Requestors: arthas [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.06000
Fixed in: (no value)



Subject: This module should depend on Class::ISA for tests to pass
Some tests depend on Class::ISA, which hasn't been core since 5.14. The test should either be fixed or a dependency on Class::ISA should be added. Attached is a patch which chooses the latter of the fixes. Full bug while building: Created MYMETA.yml and MYMETA.json Creating new 'Build' script for 'DBIx-Class-DigestColumns' version '0.06000' (/home/mb/perl5/perlbrew/perls/perl-5.18.0/bin/perl Build.PL exited with 0) CPAN::Reporter: Build.PL result is 'pass', No errors. CPAN: Module::CoreList loaded ok (v2.90) Building DBIx-Class-DigestColumns (./Build exited with 0) CPAN::Reporter: Build result is 'pass', No errors. GRODITI/DBIx-Class-DigestColumns-0.06000.tar.gz ./Build -- OK Running Build test t/02pod.t ........ ok t/04basic.t ...... ok Can't locate Class/ISA.pm in @INC (you may need to install the Class::ISA module) (@INC contains: /home/mb/.local/share/.cpan/build/DBIx-Class-DigestColumns-0.06000-fZedcH/blib/lib /home/mb/.local/share/.cpan/build/DBIx-Class-DigestColumns-0.06000-fZedcH/blib/arch /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/x86_64-linux /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0 /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0 .) at t/05digest.t line 4. BEGIN failed--compilation aborted at t/05digest.t line 4. t/05digest.t ..... Dubious, test returned 2 (wstat 512, 0x200)
Subject: Build_PL_classISA.patch
--- Build.PL 2013-08-18 15:00:41.578686999 +0200 +++ Build_ClassISA.PL 2013-08-18 15:05:23.267032793 +0200 @@ -12,6 +12,7 @@ }, build_requires => { 'DBD::SQLite' => 1.11, + 'Class::ISA' => 0, }, recommends => { 'Digest::MD2' => 0,
On Sun Aug 18 09:07:35 2013, ARTHAS wrote: Show quoted text
> Some tests depend on Class::ISA, which hasn't been core since 5.14. > The test should either be fixed or a dependency on Class::ISA should > be added. Attached is a patch which chooses the latter of the fixes. > > Full bug while building: > > Created MYMETA.yml and MYMETA.json > Creating new 'Build' script for 'DBIx-Class-DigestColumns' version > '0.06000' > (/home/mb/perl5/perlbrew/perls/perl-5.18.0/bin/perl Build.PL exited > with 0) > CPAN::Reporter: Build.PL result is 'pass', No errors. > CPAN: Module::CoreList loaded ok (v2.90) > Building DBIx-Class-DigestColumns > (./Build exited with 0) > CPAN::Reporter: Build result is 'pass', No errors. > GRODITI/DBIx-Class-DigestColumns-0.06000.tar.gz > ./Build -- OK > Running Build test > t/02pod.t ........ ok > t/04basic.t ...... ok > Can't locate Class/ISA.pm in @INC (you may need to install the > Class::ISA module) (@INC contains: > /home/mb/.local/share/.cpan/build/DBIx-Class-DigestColumns-0.06000- > fZedcH/blib/lib /home/mb/.local/share/.cpan/build/DBIx-Class- > DigestColumns-0.06000-fZedcH/blib/arch > /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/x86_64- > linux /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0 > /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux > /home/mb/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0 .) at > t/05digest.t line 4. > BEGIN failed--compilation aborted at t/05digest.t line 4. > t/05digest.t ..... > Dubious, test returned 2 (wstat 512, 0x200)
This module is basically deprecated in favor of DBIx::Class::EncodedColumn and thus more or less abandonded. Rejecting.
Good to know! Thanks. It would then be great to put the deprecation warning in favour of DBIx::Class::EncodedColumn in the documentation. Show quoted text
> This module is basically deprecated in favor of > DBIx::Class::EncodedColumn and thus more or less abandonded. > Rejecting.