Bug #87893 for Crypt-OpenSSL-PKCS10: Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10

Fri Aug 16 05:40:36 2013 smile [...] cmile.de - Ticket created

Subject:	Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Fri, 16 Aug 2013 11:40:18 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

hello, I know it has been some years since you contributed your PKCS10 module, but I hope you still care about it :D I would like to contribute some code that I added. I needed a function to load a CSR from a PEM formatted file and functions to read the subject and keyinfo from a PKCS10 object, so I went ahead and implemented it. I forked the repo on github and pushed my modifications there: https://github.com/cmile/Crypt-OpenSSL-PKCS10 Do you think it is possible to include my code in the official version of the module? best regards smile

Fri Aug 16 18:47:40 2013 jonozzz [...] yahoo.com - Correspondence added

Hi, Wouldn't be easier if you attached a diff? I don't have access to gitpan user so I won't be able to merge the pull request very easily. -J On Fri Aug 16 05:40:36 2013, smile@cmile.de wrote: Show quoted text

> hello, > > I know it has been some years since you contributed your PKCS10 module, > but I hope you still care about it :D > > I would like to contribute some code that I added. I needed a function > to load a CSR from a PEM formatted file and functions to read the > subject and keyinfo from a PKCS10 object, so I went ahead and > implemented it. I forked the repo on github and pushed my modifications > there: > > https://github.com/cmile/Crypt-OpenSSL-PKCS10 > > Do you think it is possible to include my code in the official version > of the module? > > best regards > smile

Fri Aug 16 18:47:40 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Aug 19 11:30:10 2013 smile [...] cmile.de - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Mon, 19 Aug 2013 17:29:49 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

Hi! On 17.08.13 00:47, Ionut Turturica via RT wrote: Show quoted text

> Wouldn't be easier if you attached a diff? I don't have access to gitpan user so I won't be able to merge the pull request very easily.

I have attached a diff, hope it works. Thanks in advance! Regards smile

Message body is not shown because sender requested not to inline it.

Mon Aug 19 17:48:38 2013 jonozzz [...] yahoo.com - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Mon, 19 Aug 2013 14:48:21 -0700 (PDT)
To:	"bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org" <bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org>
From:	J <jonozzz [...] yahoo.com>

Doesn't apply cleanly for me. Are you sure you're working on the latest version 0.10? $ patch -Np1 --dry-run -i pkcs10_read_from_file_patch.txt patching file PKCS10.pm Hunk #2 succeeded at 158 (offset 5 lines). patching file PKCS10.xs Hunk #1 FAILED at 32. Hunk #2 FAILED at 554. 2 out of 2 hunks FAILED -- saving rejects to file PKCS10.xs.rej patching file t/CSR.csr patching file t/Mytest.t Hunk #4 succeeded at 43 (offset 1 line). Show quoted text

________________________________ From: smile via RT <bug-Crypt-OpenSSL-PKCS10@rt.cpan.org> To: Sent: Monday, August 19, 2013 8:30 AM Subject: Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10 Queue: Crypt-OpenSSL-PKCS10 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > Hi! On 17.08.13 00:47, Ionut Turturica via RT wrote:

> Wouldn't be easier if you attached a diff? I don't have access to gitpan user so I won't be able to merge the pull request very easily.

I have attached a diff, hope it works. Thanks in advance! Regards smile

Tue Aug 20 04:22:33 2013 smile [...] cmile.de - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Tue, 20 Aug 2013 10:22:18 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

Hi, of course I was _not_using the latest version because no one cares about updating the github mirror of the source :/ I have attached the patch that I've successfully applied to 0.10. Best regards smile

Message body is not shown because sender requested not to inline it.

Tue Aug 20 12:29:48 2013 smile [...] cmile.de - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Tue, 20 Aug 2013 18:29:28 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

Hello again, unfortunately I found a bug in my code that could lead to a segmentation fault, but I fixed it with the attached patch. It must be applied after my previous patch. Best regards and thanks smile

Message body is not shown because sender requested not to inline it.

Tue Aug 20 13:22:57 2013 jonozzz [...] yahoo.com - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Tue, 20 Aug 2013 10:22:43 -0700 (PDT)
To:	"bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org" <bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org>
From:	J <jonozzz [...] yahoo.com>

Thanks! It did work this time. 0.11 should be available on CPAN anytime now. -J Show quoted text

________________________________ From: smile via RT <bug-Crypt-OpenSSL-PKCS10@rt.cpan.org> To: Sent: Tuesday, August 20, 2013 9:29 AM Subject: Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10 Queue: Crypt-OpenSSL-PKCS10 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > Hello again, unfortunately I found a bug in my code that could lead to a segmentation fault, but I fixed it with the attached patch. It must be applied after my previous patch. Best regards and thanks smile

Wed Aug 21 03:34:19 2013 smile [...] cmile.de - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Wed, 21 Aug 2013 09:34:07 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

On 20.08.13 19:22, Ionut Turturica via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > > > Thanks! It did work this time. > 0.11 should be available on CPAN anytime now.

awesome! but I saw that it seems to fail on all systems. I assume this is because the t/CSR.csr file is missing. I included it to test loading CSRs from a file, but it is not in the release. sorry for the trouble and thanks again smile

Message body is not shown because sender requested not to inline it.

Wed Aug 21 13:10:30 2013 jonozzz [...] yahoo.com - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Wed, 21 Aug 2013 10:10:15 -0700 (PDT)
To:	"bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org" <bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org>
From:	J <jonozzz [...] yahoo.com>

Yeah, I saw that. You forgot to include it in the MANIFEST. Show quoted text

________________________________ From: smile via RT <bug-Crypt-OpenSSL-PKCS10@rt.cpan.org> To: Sent: Wednesday, August 21, 2013 12:34 AM Subject: Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10 Queue: Crypt-OpenSSL-PKCS10 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > On 20.08.13 19:22, Ionut Turturica via RT wrote:

> <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > > > Thanks! It did work this time. > 0.11 should be available on CPAN anytime now.

awesome! but I saw that it seems to fail on all systems. I assume this is because the t/CSR.csr file is missing. I included it to test loading CSRs from a file, but it is not in the release. sorry for the trouble and thanks again smile

Wed Aug 21 15:45:29 2013 smile [...] cmile.de - Correspondence added

Subject:	Re: [rt.cpan.org #87893] Pull Request: https://github.com/cmile/Crypt-OpenSSL-PKCS10
Date:	Wed, 21 Aug 2013 21:45:04 +0200
To:	bug-Crypt-OpenSSL-PKCS10 [...] rt.cpan.org
From:	smile <smile [...] cmile.de>

On 21.08.13 19:10, Ionut Turturica via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=87893 > > > Yeah, I saw that. You forgot to include it in the MANIFEST.

ah damn, thanks for fixing it! i guess you can close the ticket now :) cheers smile

Wed Aug 21 18:55:03 2013 jonozzz [...] yahoo.com - Correspondence added

Fixed in 0.12

Wed Aug 21 18:55:03 2013 jonozzz [...] yahoo.com - Status changed from 'open' to 'resolved'