Skip Menu |

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 87830
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: DOUGDUDE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.0019
Fixed in: (no value)



Subject: Test t/40reader.t fails from Dumper call
The test t/40reader.t fails on my system due to the line print Dumper($@) which seems to be clearing the $@ variable and so the test sees $@ as undef and fails. Removing the line fixes the test failure.
Subject: 0001-Remove-Dumper-from-test.patch
From 30a406a5763d98e9c7b701c84dc7b42ac481f3b3 Mon Sep 17 00:00:00 2001 From: Douglas Christopher Wilson <doug@somethingdoug.com> Date: Tue, 13 Aug 2013 16:56:36 -0400 Subject: [PATCH] Remove Dumper from test --- t/40reader.t | 2 -- 1 file changed, 2 deletions(-) diff --git a/t/40reader.t b/t/40reader.t index db764a7..55864a5 100644 --- a/t/40reader.t +++ b/t/40reader.t @@ -208,8 +208,6 @@ EOF URI => "mystring.xml" ); eval { $reader->finish }; - use Data::Dumper; - print Dumper($@); print $@; ok((defined $@ and $@ =~ /in mystring.xml at line 3:|mystring.xml:5:/), 'catchin error'); } -- 1.7.11.msysgit.1
Hi Douglas, thanks for the report. On Tue Aug 13 16:58:11 2013, DOUGDUDE wrote: Show quoted text
> The test t/40reader.t fails on my system due to the line > > print Dumper($@) > > which seems to be clearing the $@ variable and so the test sees $@ as > undef and fails. Removing the line fixes the test failure.
I applied a different fix of assigning $@ to a lexical variable and I also commented out the two print statements. This is part of XML-LibXML-2.0100, which was just uploaded to CPAN. Please test. Regards, -- Shlomi Fish
Show quoted text
> I applied a different fix of assigning $@ to a lexical variable and I > also commented out the two print statements. This is part of XML- > LibXML-2.0100, which was just uploaded to CPAN. Please test. >
Thanks! I can confirm in the save environment the test was failing 2.0100 no longer fails.