Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 87790
Status: resolved
Priority: 0/
Queue: CGI
People
Owner: Nobody in particular
Requestors: lpsolit [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Aug 12 07:28:09 2013 lpsolit [...] gmail.com - Ticket created
Subject: url() shouldn't call query_string() unless needed
Date: Mon, 12 Aug 2013 13:27:52 +0200
To: bug-CGI.pm [...] rt.cpan.org
From: "Frédéric Buclin" <lpsolit [...] gmail.com>
Despite I call url() *without* query => 1, it calls query_string() anyway which is quite slow when the URL contains several hundreds of parameters (900 in my case): 70 ms per call! And I call this method several times in a single CGI script so that's quite annoying as the time penalty becomes very visible (0.3 second). The fix in url() is trivial: --- CGI.pm 2013-08-12 13:18:56.388940276 +0200 +++ CGI.pm 2013-08-12 13:19:06.518713206 +0200 @@ -2817,7 +2817,7 @@ sub url { my $path = $self->path_info; my $script_name = $self->script_name; my $request_uri = unescape($self->request_uri) || ''; - my $query_str = $self->query_string; + my $query_str = $query ? $self->query_string : ''; my $rewrite_in_use = $request_uri && $request_uri !~ /^\Q$script_name/; Could you please include this fix for CGI 3.64? :)
  Mon Aug 12 08:54:19 2013 mark [...] stosberg.com - Correspondence added
Subject: Re: [rt.cpan.org #87790] url() shouldn't call query_string() unless needed
Date: Mon, 12 Aug 2013 05:54:02 -0700
To: Frédéric Buclin via RT <bug-CGI.pm [...] rt.cpan.org>
From: Mark Stosberg <mark [...] stosberg.com>
Can you confirm that: 1. There is sufficient test coverage for the related cases. 2. The full test suite passes after the change? Mark On Mon, Aug 12, 2013, at 04:28 AM, Frédéric Buclin via RT wrote: Show quoted text
> Mon Aug 12 07:28:09 2013: Request 87790 was acted upon. > Transaction: Ticket created by lpsolit@gmail.com > Queue: CGI.pm > Subject: url() shouldn't call query_string() unless needed > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: lpsolit@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87790 > > > > Despite I call url() *without* query => 1, it calls query_string() > anyway which is quite slow when the URL contains several hundreds of > parameters (900 in my case): 70 ms per call! And I call this method > several times in a single CGI script so that's quite annoying as the > time penalty becomes very visible (0.3 second). The fix in url() is > trivial: > > > --- CGI.pm 2013-08-12 13:18:56.388940276 +0200 > +++ CGI.pm 2013-08-12 13:19:06.518713206 +0200 > @@ -2817,7 +2817,7 @@ sub url { > my $path = $self->path_info; > my $script_name = $self->script_name; > my $request_uri = unescape($self->request_uri) || ''; > - my $query_str = $self->query_string; > + my $query_str = $query ? $self->query_string : ''; > > my $rewrite_in_use = $request_uri && $request_uri !~ > /^\Q$script_name/; > > > Could you please include this fix for CGI 3.64? :) > >
  Mon Aug 12 08:54:19 2013 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 12 08:58:57 2013 lpsolit [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #87790] url() shouldn't call query_string() unless needed
Date: Mon, 12 Aug 2013 14:58:36 +0200
To: bug-CGI.pm [...] rt.cpan.org
From: "Frédéric Buclin" <lpsolit [...] gmail.com>
Le 12. 08. 13 14:54, Mark Stosberg via RT a écrit : Show quoted text
> Can you confirm that: > > 1. There is sufficient test coverage for the related cases. > 2. The full test suite passes after the change?
I really don't see how this could break stuff. Just look at the code itself: sub url { ... my $query_str = $self->query_string; ... $url .= "?$query_str" if $query and $query_str ne ''; } That's the only 2 lines which use $query_str. All my patch does is to skip a useless and time consuming call to query_string() when it's ignored a few lines later.
  Thu May 22 08:19:26 2014 LEEJO [...] cpan.org - Correspondence added
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/121 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
  Fri May 23 14:28:12 2014 The RT System itself - Queue changed from CGI.pm to CGI
  Sat Sep 20 11:55:20 2014 LEEJO [...] cpan.org - Correspondence added
commit e960d905c33009585ac594d4a88a91057b84c8b1 Author: Lee Johnson <lee@givengain.ch> Date: Sat Sep 20 16:54:18 2014 +0100 resolve #121 [rt.cpan.org #87790] - optimise url by not calling ->query_string if -query is not passed to the method since we *don't* append the query_string anyway in this case Changes | 2 ++ lib/CGI.pm | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
  Sat Sep 20 11:55:21 2014 LEEJO [...] cpan.org - Status changed from 'open' to 'resolved'