| Subject: | patches from Debian |
Hi,
I'm attaching four patches that have been included in the Debian package for Module-Info for a few years. They're all about fairly minor nitpicks with POD spelling and tests, but still I felt it'd be useful to push them upstream. All patches were developed by Ansgar Burchard.
thanks,
Florian
| Subject: | is-deeply.patch |
From: Ansgar Burchardt <ansgar@43-1.org>
Date: Sun, 06 Jun 2010 21:40:08 +0900
Origin: vendor
Subject: Use is_deeply correctly
--- a/t/Module-Info.t
+++ b/t/Module-Info.t
@@ -300,6 +300,6 @@
$module = Module::Info->new_from_file('t/lib/Bar.pm');
@mods = $module->modules_used;
is( @mods, 3, 'modules_used with complex BEGIN block' );
- is_deeply( sort @mods,
- (sort qw(Cwd Carp strict)) );
+ is_deeply( [sort @mods],
+ [sort qw(Cwd Carp strict)] );
}
| Subject: | spelling.patch |
From: Ansgar Burchardt <ansgar@43-1.org>
Date: Sun, 06 Jun 2010 21:44:25 +0900
Origin: vendor
Subject: Fix spelling errors
--- a/bin/module_info
+++ b/bin/module_info
@@ -2,7 +2,7 @@
=head1 NAME
-module_info - find informations about modules
+module_info - find information about modules
=head1 SYNOPSIS
@@ -14,7 +14,7 @@
C<Module::Name> or paths in the form C<Foo/Bar.pm> or C<foo/bar.pl>).
By default only shows module name, version, directory, absolute path
-and a flag indicating if it is a core module. Additional informations
+and a flag indicating if it is a core module. Additional information
can be requested through command line switches.
=over 4
--- a/lib/Module/Info.pm
+++ b/lib/Module/Info.pm
@@ -320,7 +320,7 @@
The following methods get their information by compiling the module
and examining the opcode tree. The module will be compiled in a
-seperate process so as not to disturb the current program.
+separate process so as not to disturb the current program.
They will only work on 5.6.1 and up and requires the B::Utils module.
@@ -734,7 +734,7 @@
Code refs in @INC are currently ignored. If this bothers you submit a
patch.
-superclasses() is cheating and just loading the module in a seperate
+superclasses() is cheating and just loading the module in a separate
process and looking at @ISA. I don't think its worth the trouble to
go through and parse the opcode tree as it still requires loading the
module and running all the BEGIN blocks. Patches welcome.
| Subject: | version-comparison.patch |
From: Ansgar Burchardt <ansgar@43-1.org>
Date: Sun, 06 Jun 2010 21:35:17 +0900
Origin: vendor
Subject: Compare versions as numbers, not as strings
--- libmodule-info-perl.orig/t/n3_version.t
+++ libmodule-info-perl/t/n3_version.t
@@ -20,18 +20,18 @@
}
is( $moo->use_version, 0 );
-is( $moo->version, '0.12' );
-is( $boo->version, '1.35', 'proper quoting in complex expression' );
+is( $moo->version, 0.12 );
+is( $boo->version, 1.35, 'proper quoting in complex expression' );
SKIP: {
skip 'version.pm not found', 5 unless $has_version_pm;
is( $moo_ver->use_version, 1 );
isa_ok( $moo_ver->version, 'version' );
- is( $moo_ver->version, '0.120' );
+ is( $moo_ver->version, 0.120 );
isa_ok( $foo_ver->version, 'version' );
- is( $foo_ver->version, '7.254' );
+ is( $foo_ver->version, 7.254 );
}
SKIP: {
| Subject: | whatis-entry.patch |
From: Ansgar Burchardt <ansgar@43-1.org>
Date: Sun, 06 Jun 2010 21:47:36 +0900
Origin: vendor
Subject: Add missing whatis entry
It might be better to remove the POD from this module, but maybe somebody will
someday want to read it...
--- libmodule-info-perl.orig/lib/B/Module/Info.pm
+++ libmodule-info-perl/lib/B/Module/Info.pm
@@ -7,6 +7,12 @@
opgrep all_roots);
@B::Utils::bad_stashes = qw(); # give us everything.
+=head1 NAME
+
+B::Module::Info - information about Perl modules
+
+=cut
+
{
# From: Roland Walker <walker@ncbi.nlm.nih.gov>
# "Syntax OK" may land inside output and render it unusable