Skip Menu |

This queue is for tickets about the App-FatPacker CPAN distribution.

Report information
The Basics
Id: 87766
Status: open
Priority: 0/
Queue: App-FatPacker
People
Owner: Nobody in particular
Requestors: miyagawa [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Aug 11 00:46:27 2013 miyagawa [...] gmail.com - Ticket created
Subject: Probably should use modules without import on Trace
Date: Sat, 10 Aug 2013 21:45:57 -0700
To: bug-app-fatpacker <bug-App-FatPacker [...] rt.cpan.org>
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
I have an automated script to add extra modules to fatpacker, and if you pass 'local::lib' to it (because my runtime executable wants it), the Trace module does eval "use local::lib" which triggers its import() and then @INC gets messed up in the process and fatpacker doesn't load modules from the right place. It might be rare to bundle local::lib, but it's perfectly legit, and i think Trace should be fixed to not call import (i.e. eval "use $_ ()") as a safe-guard. -- Tatsuhiko Miyagawa
  Sun Aug 11 01:25:44 2013 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #87766] Probably should use modules without import on Trace
Date: Sat, 10 Aug 2013 22:25:28 -0700
To: "miyagawa [...] gmail.com via RT" <bug-App-FatPacker [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Sun, Aug 11, 2013 at 12:46:29AM -0400, miyagawa@gmail.com via RT wrote: Show quoted text
> It might be rare to bundle local::lib, but it's perfectly legit, and i > think Trace should be fixed to not call import (i.e. eval "use $_ ()") > as a safe-guard.
I'm confused - don't we call B::minus_c to prevent side effects? But yes, I don't see any reason why we want to call the target's import sub.
  Sun Aug 11 01:25:46 2013 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 11 02:01:03 2013 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #87766] Probably should use modules without import on Trace
Date: Sat, 10 Aug 2013 23:00:28 -0700
To: bug-app-fatpacker <bug-App-FatPacker [...] rt.cpan.org>
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
On Sat, Aug 10, 2013 at 10:25 PM, Karen Etheridge via RT <bug-App-FatPacker@rt.cpan.org> wrote: Show quoted text
> I'm confused - don't we call B::minus_c to prevent side effects?
modules are loaded before calling B::minus_c. # Use any extra modules specified eval "use $_" for @extras; B::minus_c; -- Tatsuhiko Miyagawa