Skip Menu |

This queue is for tickets about the Module-Rename CPAN distribution.

Report information
The Basics
Id: 87757
Status: resolved
Priority: 0/
Queue: Module-Rename
People
Owner: Nobody in particular
Requestors: jim.cochrane [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Aug 09 20:09:01 2013 jim.cochrane [...] gmail.com - Ticket created
Subject: Incorrect directory restructuring under certain conditions
Date: Fri, 9 Aug 2013 19:08:49 -0500
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
This is a formal report of the bug I reported earlier in the context of another bug: https://rt.cpan.org/Public/Bug/Display.html?id=87172 The bug causes the wrong directory hierarchy to be created in some cases. For example, I have a test case that, from the commands: module-rename -g NowOrLater::Core::TaskState NowOrLater::Core::Tasks::TaskState lib/ module-rename -g NowOrLater::Core::Task NowOrLater::Core::Tasks::Task lib/ transforms this hierarchy: lib/NowOrLater/Core/TaskState.pm lib/NowOrLater/Core/Task.pm lib/NowOrLater.pm into this incorrect one: lib/NowOrLater/Core/Tasks/Task.pm lib/NowOrLater/Core/Tasks/Tasks/TaskState.pm lib/NowOrLater.pm (.../Tasks/Tasks/TaskState.pm is wrong.) The correct hierarchy is: lib/NowOrLater/Core/Tasks/TaskState.pm lib/NowOrLater/Core/Tasks/Task.pm lib/NowOrLater.pm More info about this bug can be found in the thread for bug 87172 - e.g.: https://rt.cpan.org/Public/Bug/Display.html?id=87172#txn-1243696
  Sat Aug 10 11:58:25 2013 jim.cochrane [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #87757] AutoReply: Incorrect directory restructuring under certain conditions
Date: Sat, 10 Aug 2013 10:58:11 -0500
To: bug-Module-Rename [...] rt.cpan.org
From: Jim Cochrane <jim.cochrane [...] gmail.com>
I created a pull request on github for my fix for this bug, along with an enhancement for a -t/trial_run option (i.e., report, but don't make changes to files/dirs): https://github.com/mschilli/module-rename-perl/pull/2 On Fri, Aug 9, 2013 at 7:09 PM, Bugs in Module-Rename via RT < bug-Module-Rename@rt.cpan.org> wrote: Show quoted text
> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Incorrect directory restructuring under certain conditions", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #87757]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=87757 > > Please include the string: > > [rt.cpan.org #87757] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > bug-Module-Rename@rt.cpan.org > > ------------------------------------------------------------------------- > This is a formal report of the bug I reported earlier in the context of > another bug: > > https://rt.cpan.org/Public/Bug/Display.html?id=87172 > > The bug causes the wrong directory hierarchy to be created in some cases. > For example, I have a test case that, from the commands: > > module-rename -g NowOrLater::Core::TaskState > NowOrLater::Core::Tasks::TaskState lib/ > > module-rename -g NowOrLater::Core::Task NowOrLater::Core::Tasks::Task lib/ > > transforms this hierarchy: > > lib/NowOrLater/Core/TaskState.pm lib/NowOrLater/Core/Task.pm > lib/NowOrLater.pm > > into this incorrect one: > > lib/NowOrLater/Core/Tasks/Task.pm > lib/NowOrLater/Core/Tasks/Tasks/TaskState.pm > lib/NowOrLater.pm > > (.../Tasks/Tasks/TaskState.pm is wrong.) The correct hierarchy is: > > lib/NowOrLater/Core/Tasks/TaskState.pm lib/NowOrLater/Core/Tasks/Task.pm > lib/NowOrLater.pm > > More info about this bug can be found in the thread for bug > 87172 - e.g.: > > https://rt.cpan.org/Public/Bug/Display.html?id=87172#txn-1243696 >
  Sun Aug 11 00:02:37 2013 MSCHILLI [...] cpan.org - Correspondence added
On Sat Aug 10 11:58:25 2013, jim.cochrane@gmail.com wrote: Show quoted text
> I created a pull request on github for my fix for this bug, along with an > enhancement for a -t/trial_run option
I like your -t option, applied with a few minor changes (mainly because Sysadm::Install already has a "dry_run" mode that we can utilize). As for the rename bugfix, please see my reply to [rt.cpan.org #87172].
  Sun Aug 11 00:02:38 2013 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 11 00:02:38 2013 MSCHILLI [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Aug 11 00:03:50 2013 MSCHILLI [...] cpan.org - Correspondence added
Code changes for reference: https://github.com/mschilli/module-rename-perl/commit/244de58a1b90b06288f71d7f1ea3c3299e433c72