| Subject: | [PATCH] Test::Harness fails to install when first perl in path isnt the version of perl the install is running for |
If a user with multiple versions of Perl installed also has multiple Perl/bin directories in their path and they happen to try to install Test::Harness for a version which is not first in the path the install fails. This happens because "prove" gets executed without specifying the perl executable to use to execute it. Ie, if E:/Activestate/638/Perl/bin is the first perl in the path and you do:
Show quoted text
> E:/Activestate/810/Perl/bin/Perl.exe makefile.pl
> nmake test
Then you'll get an error.
The attached patch would seem to fix this.
Cheers,
yves
diff -wurd build\Test-Harness-2.44/t/prove-globbing.t patched\Test-Harness-2.44/t/prove-globbing.t
--- build\Test-Harness-2.44/t/prove-globbing.t 2004-03-28 07:01:22.000000000 +0200
+++ patched\Test-Harness-2.44/t/prove-globbing.t 2004-12-07 15:36:42.308750000 +0100
@@ -20,7 +20,7 @@
my $tests = File::Spec->catfile( 't', 'prove*.t' );
GLOBBAGE: {
- my @actual = sort qx/$prove --dry $tests/;
+ my @actual = sort qx/$^X $prove --dry $tests/;
chomp @actual;
my @expected = (
diff -wurd build\Test-Harness-2.44/t/prove-switches.t patched\Test-Harness-2.44/t/prove-switches.t
--- build\Test-Harness-2.44/t/prove-switches.t 2004-08-08 23:17:50.000000000 +0200
+++ patched\Test-Harness-2.44/t/prove-switches.t 2004-12-07 15:37:11.558750000 +0100
@@ -29,7 +29,7 @@
local $ENV{PROVE_SWITCHES};
local $/ = undef;
- my @actual = qx/$prove -Ifirst -D -I second -Ithird -Tvdb/;
+ my @actual = qx/$^X $prove -Ifirst -D -I second -Ithird -Tvdb/;
my @expected = ( "# \$Test::Harness::Switches: -T -I$blib_arch -I$blib_lib -Ifirst -Isecond -Ithird\n" );
is_deeply( \@actual, \@expected, "Capital taint flags OK" );
}
@@ -38,7 +38,7 @@
local $ENV{PROVE_SWITCHES};
local $/ = undef;
- my @actual = qx/$prove -dD -Ifirst -I second -t -Ithird -vb/;
+ my @actual = qx/$^X $prove -dD -Ifirst -I second -t -Ithird -vb/;
my @expected = ( "# \$Test::Harness::Switches: -t -I$blib_arch -I$blib_lib -Ifirst -Isecond -Ithird\n" );
is_deeply( \@actual, \@expected, "Lowercase taint OK" );
}
@@ -47,7 +47,7 @@
local $ENV{PROVE_SWITCHES} = "-dvb -I fark";
local $/ = undef;
- my @actual = qx/$prove -Ibork -Dd/;
+ my @actual = qx/$^X $prove -Ibork -Dd/;
my @expected = ( "# \$Test::Harness::Switches: -I$blib_arch -I$blib_lib -Ifark -Ibork\n" );
is_deeply( \@actual, \@expected, "PROVE_SWITCHES OK" );
}
@@ -55,7 +55,7 @@
PROVE_SWITCHES_L: {
local $/ = undef;
- my @actual = qx/$prove -l -Ibongo -Dd/;
+ my @actual = qx/$^X $prove -l -Ibongo -Dd/;
my @expected = ( "# \$Test::Harness::Switches: -Ilib -Ibongo\n" );
is_deeply( \@actual, \@expected, "PROVE_SWITCHES OK" );
}
@@ -63,7 +63,7 @@
PROVE_SWITCHES_LB: {
local $/ = undef;
- my @actual = qx/$prove -lb -Dd/;
+ my @actual = qx/$^X $prove -lb -Dd/;
my @expected = ( "# \$Test::Harness::Switches: -Ilib -I$blib_arch -I$blib_lib\n" );
is_deeply( \@actual, \@expected, "PROVE_SWITCHES OK" );
}