Bug #87583 for ExtUtils-H2PM: Unit tests fail on ARM

Sun Aug 04 01:20:44 2013 http://bochecha.id.fedoraproject.org/ - Ticket created

Subject:

Unit tests fail on ARM

The unit tests when running them on an ARM machine, as in the Fedora build system. See the full logs: http://kojipkgs.fedoraproject.org//work/tasks/9800/5739800/build.log

Sun Aug 04 01:37:41 2013 http://bochecha.id.fedoraproject.org/ - Correspondence added

Attaching the log file here, in case the one on Koji gets cleaned up.

Subject:

build-failure.log

Download build-failure.log
application/octet-stream 6.5k

Message body not shown because it is not plain text.

Sun Aug 04 01:37:42 2013 The RT System itself - Status changed from 'new' to 'open'

Sun Aug 04 18:41:43 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Ahhah. That'll be the C compiler defaulting "char" to unsigned rather than signed behaviour, as most others do. Surprised this hasn't come up before in fact. I guess the test.h file should be more specific about it. The attached patch should fix it. -- Paul Evans

Subject:

rt87583.patch

=== modified file 't/test.h' --- t/test.h 2010-02-19 02:15:01 +0000 +++ t/test.h 2013-08-04 22:40:19 +0000 @@ -16,7 +16,7 @@ struct msghdr { int cmd; - char vers; + signed char vers; // Be specific on signedness /* hope there's a hole here */ };

Sun Aug 04 18:41:44 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Sun Aug 04 23:33:09 2013 http://bochecha.id.fedoraproject.org/ - Correspondence added

On Sun Aug 04 18:41:43 2013, PEVANS wrote: Show quoted text

> Ahhah. That'll be the C compiler defaulting "char" to unsigned rather > than signed behaviour, as most others do. Surprised this hasn't come > up before in fact. > > I guess the test.h file should be more specific about it. The attached > patch should fix it.

It does fix it, thanks for being so quick! Here's the relevant portion of the build log on an ARM builder: + ./Build test t/00use.t ........................ ok t/01constant.t ................... ok t/02structure-numeric.t .......... ok t/03structure-strarray.t ......... ok t/10structure-with-tail.t ........ ok t/11structure-args-hashref.t ..... ok t/12structure-no-length-check.t .. ok t/99pod.t ........................ skipped: Test::Pod 1.00 required for testing POD All tests successful. Files=8, Tests=33, 9 wallclock secs ( 0.12 usr 0.04 sys + 7.13 cusr 1.05 csys = 8.34 CPU) Result: PASS Will there be a release soon with this change included? Otherwise I can just include the patch in the Fedora package for now, if you prefer. :)

Mon Aug 05 06:26:46 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Sun Aug 04 23:33:09 2013, http://bochecha.id.fedoraproject.org/ wrote: Show quoted text

> Will there be a release soon with this change included? Otherwise I > can just include the patch in the Fedora package for now, if you > prefer. :)

I'll release it as-is then - I was just waiting to see if that fixed it. -- Paul Evans

Sat Aug 31 20:00:37 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released as 0.09 -- Paul Evans

Sat Aug 31 20:00:37 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Sat Aug 31 20:00:38 2013 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.09 added