Bug #87495 for Test-Exit: exit override has wrong precedence / prototype

Wed Jul 31 16:01:32 2013 MAUKE [...] cpan.org - Ticket created

Subject:

exit override has wrong precedence / prototype

% perl -e 'my @x = 0; exit @x'; echo $? 1 % perl -e 'use Test::Exit; my @x = 0; exit @x'; echo $? 0 These two should produce the same output. % perl -e 'exit 0 | 1'; echo $? 0 % perl -e 'use Test::Exit; exit 0 | 1'; echo $? 1 As should these. Test::Exit's 'exit' override lacks CORE::exit's (;$) prototype that gives it higher precedence and forces scalar context on the argument.

Wed Jul 31 16:06:29 2013 MAUKE [...] cpan.org - Correspondence added

On Wed Jul 31 16:01:32 2013, MAUKE wrote: Show quoted text

> Test::Exit's 'exit' override lacks CORE::exit's (;$) prototype that > gives it higher precedence and forces scalar context on the argument.

Patch attached.

Subject:

Test-Exit-prototype.patch

diff -ru Test-Exit-0.03-hax/lib/Test/Exit.pm Test-Exit-0.03/lib/Test/Exit.pm --- Test-Exit-0.03-hax/lib/Test/Exit.pm 2013-07-31 22:02:48.000000000 +0200 +++ Test-Exit-0.03/lib/Test/Exit.pm 2009-12-04 11:42:55.000000000 +0100 @@ -19,7 +19,7 @@ CORE::exit $value; }; BEGIN { - *CORE::GLOBAL::exit = sub (;$) { $exit_handler->(@_) }; + *CORE::GLOBAL::exit = sub { $exit_handler->(@_) }; }

Wed Jul 31 16:07:41 2013 MAUKE [...] cpan.org - Correspondence added

On Wed Jul 31 16:06:29 2013, MAUKE wrote: Show quoted text

> On Wed Jul 31 16:01:32 2013, MAUKE wrote:

> > Test::Exit's 'exit' override lacks CORE::exit's (;$) prototype that > > gives it higher precedence and forces scalar context on the argument.

> > Patch attached.

Sigh. The above patch is reversed. Fixed version attached.

Subject:

Test-Exit-prototype.patch

diff -ru Test-Exit-0.03/lib/Test/Exit.pm Test-Exit-0.03-hax/lib/Test/Exit.pm --- Test-Exit-0.03/lib/Test/Exit.pm 2009-12-04 11:42:55.000000000 +0100 +++ Test-Exit-0.03-hax/lib/Test/Exit.pm 2013-07-31 22:02:48.000000000 +0200 @@ -19,7 +19,7 @@ CORE::exit $value; }; BEGIN { - *CORE::GLOBAL::exit = sub { $exit_handler->(@_) }; + *CORE::GLOBAL::exit = sub (;$) { $exit_handler->(@_) }; }

Thu Aug 01 00:54:50 2013 ARODLAND [...] cpan.org - Status changed from 'new' to 'resolved'