Skip Menu |

This queue is for tickets about the IO-Pager CPAN distribution.

Report information
The Basics
Id: 87463
Status: rejected
Priority: 0/
Queue: IO-Pager

People
Owner: jpierce [...] cpan.org
Requestors: dwheeler [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.30
Fixed in: 0.31



Subject: Unbuffered.pm Returns Unconnected File Handle
Date: Tue, 30 Jul 2013 23:32:55 +0200
To: "bug-IO-Pager [...] rt.cpan.org bug-IO-Pager [...] rt.cpan.org" <bug-io-pager [...] rt.cpan.org>
From: "David E. Wheeler" <dwheeler [...] cpan.org>
When IO::Pager detects no TTY, IO::Pager::Unbuffered returns an IO::Handle object. However, it neglects to hook up the handle to the file. This patch should fix that problem. --- a/lib/IO/Pager/Unbuffered.pm +++ b/lib/IO/Pager/Unbuffered.pm @@ -16,7 +16,8 @@ sub new(;$) { # [FH], procedural return $_[1] if defined($_[2]) && $_[2] eq 'procedural'; #...fall back to IO::Handle for transparent OO programming - eval "require IO::Handle" && return new IO::Handle; + eval "require IO::Handle" or die $@; + return IO::Handle->new_from_fd(fileno($_[1]), 'w'); } $!=$@, return 0 if $@ =~ 'pipe'; Best, David
Subject: Re: [rt.cpan.org #87463] Unbuffered.pm Returns Unconnected File Handle
Date: Thu, 14 Nov 2013 09:50:43 -0500
To: bug-IO-Pager [...] rt.cpan.org
From: Jerrad Pierce <belg4mit [...] pthbb.org>
Sorry for the delay, but I'm not hacking much perl these days :-/ I'll try to get to it this weekend. Alternatively, would you like commit bits?
Subject: Re: [rt.cpan.org #87463] Unbuffered.pm Returns Unconnected File Handle
Date: Thu, 14 Nov 2013 08:01:28 -0800
To: bug-IO-Pager [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Nov 14, 2013, at 6:51 AM, belg4mit@pthbb.org via RT <bug-IO-Pager@rt.cpan.org> wrote: Show quoted text
> Sorry for the delay, but I'm not hacking much perl these days :-/ > I'll try to get to it this weekend. Alternatively, would you like commit bits?
I could easily apply that change, it's a 30s job. It's releasing an updated version that would take a bit longer. David
On 2013-11-14 09:51:00, belg4mit@pthbb.org wrote: Show quoted text
> Sorry for the delay, but I'm not hacking much perl these days :-/ > I'll try to get to it this weekend. Alternatively, would you like > commit bits?
Hi, any chance of getting this fix into the wild? Thanks, David
'Tis a blizzard today, so I'll see if I can figure out what's going on with my local branch and if I can get a release out. However, in case that does not happen, I've granted you commit bits for PAUSE. Florent Angly holds the github ACLs at the moment: https://github.com/fangly/io-pager
Your patch seems to be against 0.30, not the current 0.31. Although I should probably be dieing if the eval fails, 0.31 already returns the filehandle in a manner similar to what you propose.
Subject: Re: [rt.cpan.org #87463] Unbuffered.pm Returns Unconnected File Handle
Date: Mon, 16 Feb 2015 09:01:21 -0800
To: bug-IO-Pager [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Feb 15, 2015, at 9:10 AM, Jerrad Pierce via RT <bug-IO-Pager@rt.cpan.org> wrote: Show quoted text
> Your patch seems to be against 0.30, not the current 0.31. Although I should probably be dieing if the eval fails, 0.31 already returns the filehandle in a manner similar to what you propose.
Ah, so it does, great. This issue can be closed, then, methinks. David