Skip Menu |

This queue is for tickets about the HTML-FormatText-WithLinks-AndTables CPAN distribution.

Report information
The Basics
Id: 87457
Status: resolved
Priority: 0/
Queue: HTML-FormatText-WithLinks-AndTables

People
Owner: Nobody in particular
Requestors: eyedareu2treye [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.06



Subject: Issue with empty tables, uninitialized $new_text in line 230 (v0.02)
Date: Tue, 30 Jul 2013 14:27:00 -0500
To: bug-HTML-FormatText-WithLinks-AndTables [...] rt.cpan.org
From: James Rushing <eyedareu2treye [...] gmail.com>
I found a fairly minor issue on 0.02 which requires an easy fix. I ran into a web page that had empty <td> within the confines a <tr> and was producing the following error message: Use of uninitialized value in substitution (s///) at /opt/local/lib/perl5/site_perl/5.12.4/HTML/FormatText/WithLinks/AndTables.pm line 231. Pretty easy fix for this - I just added a defined check, as follows: 230 my $new_text = $$formatted_tables[$i][$j]; 231 if (defined $new_text) { # added this check in case the table is empty 232 $text =~ s/$token/$new_text/; 233 } No more errors. Cheers, -J
Subject: Re: [rt.cpan.org #87457] AutoReply: Issue with empty tables, uninitialized $new_text in line 230 (v0.02)
Date: Tue, 30 Jul 2013 20:26:53 -0500
To: bug-HTML-FormatText-WithLinks-AndTables [...] rt.cpan.org
From: James Rushing <eyedareu2treye [...] gmail.com>
Well...I managed to fix the STDERR output from the module...but I created another problem. The TOKEN strings associated with those empty <td>s are not getting cleared out as a result, so it's bag to the drawing board on the required fix. -J On Tue, Jul 30, 2013 at 2:27 PM, Bugs in HTML-FormatText-WithLinks-AndTables via RT < bug-HTML-FormatText-WithLinks-AndTables@rt.cpan.org> wrote: Show quoted text
> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Issue with empty tables, uninitialized $new_text in line 230 > (v0.02)", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #87457]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=87457 > > Please include the string: > > [rt.cpan.org #87457] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > > bug-HTML-FormatText-WithLinks-AndTables@rt.cpan.org > > ------------------------------------------------------------------------- > I found a fairly minor issue on 0.02 which requires an easy fix. > > I ran into a web page that had empty <td> within the confines a <tr> and > was producing the following error message: > > > Use of uninitialized value in substitution (s///) at > > /opt/local/lib/perl5/site_perl/5.12.4/HTML/FormatText/WithLinks/AndTables.pm > line 231. > > > Pretty easy fix for this - I just added a defined check, as follows: > > 230 my $new_text = $$formatted_tables[$i][$j]; > 231 if (defined $new_text) { # added this check in case the > table is empty > 232 $text =~ s/$token/$new_text/; > 233 } > > > No more errors. > > Cheers, > -J >
Subject: Re: [rt.cpan.org #87457] AutoReply: Issue with empty tables, uninitialized $new_text in line 230 (v0.02)
Date: Tue, 30 Jul 2013 20:31:57 -0500
To: bug-HTML-FormatText-WithLinks-AndTables [...] rt.cpan.org
From: James Rushing <eyedareu2treye [...] gmail.com>
10 seconds more thought, here's the apparent fix: 231 if (defined $new_text) { # to handle <tr>s with empty <td>s 232 $text =~ s/$token/$new_text/; 233 } else { 234 $text =~ s/$token//; 235 } On Tue, Jul 30, 2013 at 8:26 PM, James Rushing <eyedareu2treye@gmail.com>wrote: Show quoted text
> Well...I managed to fix the STDERR output from the module...but I created > another problem. > > The TOKEN strings associated with those empty <td>s are not getting > cleared out as a result, so it's bag to the drawing board on the required > fix. > > -J > > > > On Tue, Jul 30, 2013 at 2:27 PM, Bugs in > HTML-FormatText-WithLinks-AndTables via RT < > bug-HTML-FormatText-WithLinks-AndTables@rt.cpan.org> wrote: >
>> >> Greetings, >> >> This message has been automatically generated in response to the >> creation of a trouble ticket regarding: >> "Issue with empty tables, uninitialized $new_text in line 230 >> (v0.02)", >> a summary of which appears below. >> >> There is no need to reply to this message right now. Your ticket has been >> assigned an ID of [rt.cpan.org #87457]. Your ticket is accessible >> on the web at: >> >> https://rt.cpan.org/Ticket/Display.html?id=87457 >> >> Please include the string: >> >> [rt.cpan.org #87457] >> >> in the subject line of all future correspondence about this issue. To do >> so, >> you may reply to this message. >> >> Thank you, >> >> bug-HTML-FormatText-WithLinks-AndTables@rt.cpan.org >> >> ------------------------------------------------------------------------- >> I found a fairly minor issue on 0.02 which requires an easy fix. >> >> I ran into a web page that had empty <td> within the confines a <tr> and >> was producing the following error message: >> >> >> Use of uninitialized value in substitution (s///) at >> >> /opt/local/lib/perl5/site_perl/5.12.4/HTML/FormatText/WithLinks/AndTables.pm >> line 231. >> >> >> Pretty easy fix for this - I just added a defined check, as follows: >> >> 230 my $new_text = $$formatted_tables[$i][$j]; >> 231 if (defined $new_text) { # added this check in case the >> table is empty >> 232 $text =~ s/$token/$new_text/; >> 233 } >> >> >> No more errors. >> >> Cheers, >> -J >>
> >
This