Skip Menu |

This queue is for tickets about the CPAN-Meta-Check CPAN distribution.

Report information
The Basics
Id: 87438
Status: resolved
Priority: 0/
Queue: CPAN-Meta-Check

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.006
Fixed in: (no value)



Subject: New test added in 0.006 fails with Test-Simple 0.98_05
$ make test RELEASE_TESTING=1 PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-compile.t ............ ok # Failed test 'Conflicts give the right errors' # at t/10-basics.t line 56. # Compared $data->{"Test\:\:More"} # got : undef # expect : 'Installed version (0.9805) of Test::More is in range '== 0.9805'' # Looks like you failed 1 test of 7. t/10-basics.t ............. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests t/release-pod-coverage.t .. ok t/release-pod-syntax.t .... ok Test Summary Report ------------------- t/10-basics.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 1 Files=4, Tests=10, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.32 cusr 0.03 csys = 0.39 CPU) Result: FAIL Failed 1/4 test programs. 1/10 subtests failed. This appears to be due to Test::More::VERSION having an underscore in it initially. Hacking Test::More to get rid of the underscore prior to it being "eval"ed results in the test suite passing. Not sure if this is an issue with CPAN-Meta-Check or elsewhere.
On 2013-07-30 05:22:20, paul@city-fan.org wrote: Show quoted text
> # Failed test 'Conflicts give the right errors' > # at t/10-basics.t line 56. > # Compared $data->{"Test\:\:More"} > # got : undef > # expect : 'Installed version (0.9805) of Test::More is in range '== > 0.9805'' > # Looks like you failed 1 test of 7.
This seems to be because Module::Metadata is returning $module->version as '0.98_05', not '0.9805', so the call to $reqs->accept_module is not comparing against the right version. However, simply eval'ing this version doesn't work out right - e.g. CPAN::Meta's version of 2.131560 gets munged to 2.13156, so that string isn't as the test expects. I'm not quite sure what to do here, but it should probably be done in Module::Metadata.
On Tue Jul 30 08:22:20 2013, paul@city-fan.org wrote: Show quoted text
> This appears to be due to Test::More::VERSION having an underscore in > it initially. Hacking Test::More to get rid of the underscore prior to > it being "eval"ed results in the test suite passing. Not sure if this > is an issue with CPAN-Meta-Check or elsewhere.
I've resolved this for now in 0.007 by swapping the tests on Test::More with Test::Deep, as rjbs doesn't use underscore versions. The test is still somewhat fragile for other reasons though (relying on specific stringification of the version). The real issue is that «version->new("0.98_50") < version->new("0.9850")» Leon