Skip Menu |

This queue is for tickets about the JSON-RPC-Common CPAN distribution.

Report information
The Basics
Id: 87361
Status: resolved
Priority: 0/
Queue: JSON-RPC-Common

People
Owner: Nobody in particular
Requestors: blue [...] thisisnotmyrealemail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Syntax error in test on newer perls
This should be obvious from the cpantesters results: http://www.cpantesters.org/distro/J/JSON-RPC-Common.html The test t/marshal_http.t uses the the syntax 'for my $key qw(...)', which was previously deprecated, but now appears to be a syntax error. qw() needs parens around it to fix this.
I'm no longer maintaining this module. If you'd like to fix it, I'd be glad to hand out comaint.
From: ppisar [...] redhat.com
Dne Pá 26.čec.2013 14:05:31, blue napsal(a): Show quoted text
> This should be obvious from the cpantesters results: > http://www.cpantesters.org/distro/J/JSON-RPC-Common.html > > The test t/marshal_http.t uses the the syntax 'for my $key qw(...)', > which was previously deprecated, but now appears to be a syntax error. > qw() needs parens around it to fix this.
The fix is attached. -- Petr
Subject: JSON-RPC-Common-0.10-qw-operator-does-not-imply-parentheses.patch
From 3668f428059e5b4dcf43c5b678ffced9b432fe90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Sat, 3 Aug 2013 09:40:33 +0200 Subject: [PATCH] qw operator does not imply parentheses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=87361> Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/marshal_http.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/marshal_http.t b/t/marshal_http.t index 671098f..d4bab42 100644 --- a/t/marshal_http.t +++ b/t/marshal_http.t @@ -58,7 +58,7 @@ use JSON::RPC::Common::Marshal::HTTP; if ( $opts->{prefer_get} ) { # GET can't guarantee version, we need to scrub that foreach my $hash ( $def_1, $def_2 ) { - foreach my $key qw(version jsonrpc) { + foreach my $key (qw(version jsonrpc)) { delete $hash->{$key}; } } @@ -129,7 +129,7 @@ use JSON::RPC::Common::Marshal::HTTP; if ( $opts->{prefer_get} ) { # GET can't guarantee version, we need to scrub that foreach my $hash ( $def_1, $def_2 ) { - foreach my $key qw(version jsonrpc) { + foreach my $key (qw(version jsonrpc)) { delete $hash->{$key}; } } -- 1.8.1.4