Skip Menu |

This queue is for tickets about the Dotiac CPAN distribution.

Report information
The Basics
Id: 87304
Status: open
Priority: 0/
Queue: Dotiac

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] wrong return precedence
returns binds stronger than and, so the expressions after and are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Dotiac-0.8-returnand.patch
diff -bu ./lib/Dotiac/DTL/Value.pm~ ./lib/Dotiac/DTL/Value.pm --- ./lib/Dotiac/DTL/Value.pm~ 2009-02-05 15:40:13.000000000 -0600 +++ ./lib/Dotiac/DTL/Value.pm 2013-07-25 08:40:47.895798357 -0500 @@ -78,7 +78,7 @@ } sub scalar { - return !$_[0]->[2] and defined $_[0]->[0]; + return (!$_[0]->[2] and defined $_[0]->[0]); } sub true {
On 2013-07-25 09:43:15, rurban@x-ray.at wrote: Show quoted text
> returns binds stronger than and, so the expressions after and are ignored. > See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
This is also causing a warning in newer fails, which in turn causes test failures: # Failed test 'no warnings' # at /opt/perl-5.22.1-RC1/lib/site_perl/5.22.1/Test/NoWarnings.pm line 45. # There were 1 warning(s) # Previous test 0 '' # Possible precedence issue with control flow operator at /tmpfs/.cpan-build/2015111121/Dotiac-0.8-syUXSF/blib/lib/Dotiac/DTL/Value.pm line 81. # at /tmpfs/.cpan-build/2015111121/Dotiac-0.8-syUXSF/blib/lib/Dotiac/DTL/Value.pm line 81. # require Dotiac/DTL/Value.pm called at /tmpfs/.cpan-build/2015111121/Dotiac-0.8-syUXSF/blib/lib/Dotiac/DTL/Core.pm line 22 # require Dotiac/DTL/Core.pm called at /opt/perl-5.22.1-RC1/lib/5.22.1/base.pm line 99 ...