Skip Menu |

This queue is for tickets about the Net-Async-IRC CPAN distribution.

Report information
The Basics
Id: 87260
Status: resolved
Priority: 0/
Queue: Net-Async-IRC

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.09



Subject: [PATCH] wrong return precedence
returns binds stronger than and, so the expressions after and are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Net-Async-IRC-0.07-returnand.patch
diff -bu Net-Async-IRC-0.07-BA6fpz/lib/Net/Async/IRC/Protocol.pm~ Net-Async-IRC-0.07-BA6fpz/lib/Net/Async/IRC/Protocol.pm --- Net-Async-IRC-0.07-BA6fpz/lib/Net/Async/IRC/Protocol.pm~ 2013-05-20 11:00:59.000000000 -0500 +++ Net-Async-IRC-0.07-BA6fpz/lib/Net/Async/IRC/Protocol.pm 2013-07-24 11:29:22.940855289 -0500 @@ -234,7 +234,7 @@ { my $self = shift; return 0 unless my $connect_f = $self->{connect_f}; - return $connect_f->is_ready and !$connect_f->failure; + return $connect_f->is_ready && !$connect_f->failure; } =head2 $loggedin = $irc->is_loggedin @@ -248,7 +248,7 @@ { my $self = shift; return 0 unless my $login_f = $self->{login_f}; - return $login_f->is_ready and !$login_f->failure; + return $login_f->is_ready && !$login_f->failure; } sub on_read
On Wed Jul 24 12:33:22 2013, rurban@x-ray.at wrote: Show quoted text
> returns binds stronger than and, so the expressions after and are ignored. > See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Thanks. Will be in next version. -- Paul Evans
Released in 0.09 -- Paul Evans