Skip Menu |

This queue is for tickets about the Finance-Currency-Convert-Yahoo CPAN distribution.

Report information
The Basics
Id: 87254
Status: open
Priority: 0/
Queue: Finance-Currency-Convert-Yahoo
People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Jul 24 11:44:38 2013 rurban [...] x-ray.at - Ticket created
Subject: [PATCH] wrong return precedence, dead code
$req = new HTTP::Request ('GET',$url) or die "...could not GET.\n" and return undef and return undef is dead code.
Subject: Finance-Currency-Convert-Yahoo-0.2-deadcode.patch
diff -bu Finance-Currency-Convert-Yahoo-0.2-WO50ju/Yahoo.pm~ Finance-Currency-Convert-Yahoo-0.2-WO50ju/Yahoo.pm --- Finance-Currency-Convert-Yahoo-0.2-WO50ju/Yahoo.pm~ 2013-07-23 17:15:58.997170750 -0500 +++ Finance-Currency-Convert-Yahoo-0.2-WO50ju/Yahoo.pm 2013-07-23 17:16:56.844604879 -0500 @@ -208,7 +208,7 @@ warn "Attempting to access <$url> ...\n" if $CHAT; # Format URL request - my $req = new HTTP::Request ('GET',$url) or die "...could not GET.\n" and return undef; + my $req = new HTTP::Request ('GET',$url) or die "...could not GET.\n"; my $res = $ua->request($req); # $res is the object UA returned if (not $res->is_success()) { # If successful warn"...failed to retrieve currency document from Yahoo...\nTried: $url\n"; @@ -250,7 +250,7 @@ warn "Attempting to access <$url> ...\n" if $CHAT; # Format URL request - my $req = new HTTP::Request ('GET',$url) or die "...could not GET.\n" and return undef; + my $req = new HTTP::Request ('GET',$url) or die "...could not GET.\n"; my $res = $ua->request($req); # $res is the object UA returned if (not $res->is_success()) { # If successful warn"...failed to retrieve currency document.\n" if $CHAT;
  Wed Jul 24 12:34:27 2013 lee [...] leegoddard.net - Correspondence added
Subject: Re: [rt.cpan.org #87254] [PATCH] wrong return precedence, dead code
Date: Wed, 24 Jul 2013 18:34:10 +0200
To: bug-Finance-Currency-Convert-Yahoo [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
It is. Been a long time since I've seen the code, thanks for spotting. On 24/07/2013 17:44, Reini Urban via RT wrote: Show quoted text
> Wed Jul 24 11:44:38 2013: Request 87254 was acted upon. > Transaction: Ticket created by rurban@x-ray.at > Queue: Finance-Currency-Convert-Yahoo > Subject: [PATCH] wrong return precedence, dead code > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: rurban@x-ray.at > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87254 > > > > $req = new HTTP::Request ('GET',$url) or die "...could not GET.\n" and return undef > > and return undef is dead code.
  Wed Jul 24 12:34:28 2013 The RT System itself - Status changed from 'new' to 'open'