Skip Menu |

This queue is for tickets about the SQL-Shell CPAN distribution.

Report information
The Basics
Id: 87245
Status: resolved
Priority: 0/
Queue: SQL-Shell
People
Owner: MGUALDRON [...] cpan.org
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.14
Fixed in: 1.14_02

History Show all quoted text
  Wed Jul 24 06:22:08 2013 ppisar [...] redhat.com - Ticket created
Subject: Syntax error due to missing parentheses around qw
Perl 5.18 stopped adding implicit parentheses around qw operator in for-context. Tests fail now: syntax error at t/SQL-Shell.t line 75, near "$param qw(tracing display-mode log-mode escape enter-whitespace width longreadlen longtruncok auto-commit multiline)" Global symbol "$param" requires explicit package name at t/SQL-Shell.t line 77. syntax error at t/SQL-Shell.t line 78, near "}" syntax error at t/SQL-Shell.t line 211, near "}" Can't use global $^W in "my" at t/SQL-Shell.t line 225, near "local $^W" Global symbol "$cmd" requires explicit package name at t/SQL-Shell.t line 226. syntax error at t/SQL-Shell.t line 229, near "}" Can't use global @_ in "my" at t/SQL-Shell.t line 236, near "= @_" syntax error at t/SQL-Shell.t line 242, near "}" Can't use global @_ in "my" at t/SQL-Shell.t line 245, near "= @_" t/SQL-Shell.t has too many errors. # Looks like you planned 26 tests but actually ran 0. t/SQL-Shell.t ..... Dubious, test returned 255 (wstat 65280, 0xff00)
  Wed Jul 24 06:26:19 2013 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne St 24.čec.2013 06:22:08, ppisar napsal(a): Show quoted text
> Perl 5.18 stopped adding implicit parentheses around qw operator in > for-context. Tests fail now: > > syntax error at t/SQL-Shell.t line 75, near "$param qw(tracing
Attached patch fixes it. -- Petr
Subject: SQL-Shell-1.14-Perl-5.18-does-add-parentheses-around-qw-operator.patch
From 755a98485c2e1de3c94b005e8ec09eca013b441e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Wed, 24 Jul 2013 12:23:05 +0200 Subject: [PATCH] Perl 5.18 does add parentheses around qw operator MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=87245> Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/SQL-Shell.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/SQL-Shell.t b/t/SQL-Shell.t index 3f23835..7310e58 100644 --- a/t/SQL-Shell.t +++ b/t/SQL-Shell.t @@ -72,7 +72,7 @@ $output = execute($sqlsh, "set rubbish on"); ASSERT(scalar $output =~ /Unknown parameter 'rubbish' for set command/s, "trap invalid param"); #Invalid param values -for my $param qw(tracing display-mode log-mode escape enter-whitespace width longreadlen longtruncok auto-commit multiline) { +for my $param (qw(tracing display-mode log-mode escape enter-whitespace width longreadlen longtruncok auto-commit multiline)) { $output = execute($sqlsh, "set $param rubbish"); ASSERT(scalar $output =~ /'rubbish' is an invalid value/s, "trap invalid value for $param"); } @@ -258,4 +258,4 @@ sub renderer { { print $fh join($delim, @$row).":"; } -} \ No newline at end of file +} -- 1.8.1.4
  Tue Feb 23 12:22:59 2016 MGUALDRON [...] cpan.org - Correspondence added
Resolved in 1.14_02 and subsequent releases.
  Tue Feb 23 12:23:00 2016 The RT System itself - Status changed from 'new' to 'open'
  Tue Feb 23 12:23:06 2016 MGUALDRON [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Feb 23 12:23:08 2016 MGUALDRON [...] cpan.org - Taken
  Tue Feb 23 12:23:09 2016 MGUALDRON [...] cpan.org - Fixed in 1.14_02 added