Skip Menu |

This queue is for tickets about the DBI-Dumper CPAN distribution.

Report information
The Basics
Id: 87243
Status: new
Priority: 0/
Queue: DBI-Dumper

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.01
Fixed in: (no value)



Subject: Syntax error due to missing parentheses around qw
Perl 5.18 stopped to add implicit parentheses around qw operator in for-context. Thus tests fail now: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_use.t ..... Use of ?PATTERN? without explicit operator is deprecated at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 326. t/01_use.t ..... 1/1 # Failed test 'use DBI::Dumper;' # at t/01_use.t line 2. # Tried to use 'DBI::Dumper'. # Error: syntax error at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 325, near "$var qw(left_delim right_delim escape terminator)" # Global symbol "$var" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 326. # Global symbol "$self" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 326. # Global symbol "$var" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 326. # Global symbol "$buffer_length" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 389. # Global symbol "$data_length" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 389. # Global symbol "$bindsize" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 389. # Global symbol "$output_fh" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 391. # Global symbol "$buffer" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 391. # Global symbol "$buffer" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 392. # Global symbol "$buffer_length" requires explicit package name at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 393. # syntax error at /home/test/fedora/perl-DBI-Dumper/DBI-Dumper-2.01/blib/lib/DBI/Dumper.pm line 394, near "}"
From: ppisar [...] redhat.com
Dne St 24.čec.2013 06:11:26, ppisar napsal(a): Show quoted text
> Perl 5.18 stopped to add implicit parentheses around qw operator in > for-context. Thus tests fail now: >
Attached patch fixes it. -- Petr
Subject: DBI-Dumper-2.01-qw-does-not-produce-parentheses.patch
From 760445e637138c55ec7027b0b087e72dc5ba1880 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Wed, 24 Jul 2013 12:09:22 +0200 Subject: [PATCH] qw does not produce parentheses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=87243> Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/DBI/Dumper.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DBI/Dumper.pm b/lib/DBI/Dumper.pm index 3335028..abf7a10 100644 --- a/lib/DBI/Dumper.pm +++ b/lib/DBI/Dumper.pm @@ -322,7 +322,7 @@ sub execute { ? $start_line_num + $self->{export} : undef; # make sure variables are set to something - for my $var qw(left_delim right_delim escape terminator) { + for my $var (qw(left_delim right_delim escape terminator)) { $self->{$var} = defined $self->{$var} ? $self->{$var} : ''; } -- 1.8.1.4