Skip Menu |

This queue is for tickets about the Spark-Form CPAN distribution.

Report information
The Basics
Id: 87232
Status: resolved
Priority: 0/
Queue: Spark-Form

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.2103-TRIAL



Subject: [PATCH] wrong return precedence
returns binds stronger than or, so the expressions after or are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Spark-Form-0.2102-returnor.patch
diff -bu Spark-Form-0.2102-jagdFj/lib/Spark/Form.pm~ Spark-Form-0.2102-jagdFj/lib/Spark/Form.pm --- Spark-Form-0.2102-jagdFj/lib/Spark/Form.pm~ 2009-09-13 16:50:37.000000000 -0500 +++ Spark-Form-0.2102-jagdFj/lib/Spark/Form.pm 2013-07-23 17:24:41.324085096 -0500 @@ -199,7 +199,7 @@ my ($self, $thing) = @_; return eval { $thing->isa('Spark::Form::Field') - } or 0; + } || 0; } sub _add_custom_field {
On Tue Jul 23 18:26:32 2013, rurban@x-ray.at wrote: Show quoted text
> returns binds stronger than or, so the expressions after or are ignored. > See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Thanks. Sorry, it took me a while to notice this. The code you've patched no longer exists.