Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 87191
Status: resolved
Priority: 0/
Queue: Log-Log4perl
People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jul 23 09:25:57 2013 zefram [...] fysh.org - Ticket created
Subject: line number test failure
Date: Tue, 23 Jul 2013 14:25:44 +0100
To: bug-Log-Log4perl [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Attached patch modifies the line number handling in Log-Log4perl's test suite such that it passes on Perl 5.19.2 where the core's line number handling is buggy. The modification not only makes the test less dependent on the core's correctness, but also makes the test script more maintainable. -zefram

Message body is not shown because sender requested not to inline it.

  Tue Jul 23 23:00:34 2013 MSCHILLI [...] cpan.org - Correspondence added
On Tue Jul 23 09:25:57 2013, zefram@fysh.org wrote: Show quoted text
> Attached patch modifies the line number handling in Log-Log4perl's test > suite such that it passes on Perl 5.19.2 where the core's line number > handling is buggy. The modification not only makes the test less > dependent on the core's correctness, but also makes the test script > more maintainable. > > -zefram
Not that I condone sweeping perl core bugs under the carpet by "fixing" modules, but your fix does improve maintainabilty, so I'll turn a blind eye to it, applied :) https://github.com/mschilli/log4perl/commit/8f14cfe6d077259f0942536b7f2275040d752ff0
  Tue Jul 23 23:00:34 2013 The RT System itself - Status changed from 'new' to 'open'
  Tue Jul 23 23:00:35 2013 MSCHILLI [...] cpan.org - Status changed from 'open' to 'resolved'