Skip Menu |

This queue is for tickets about the Business-Hours CPAN distribution.

Report information
The Basics
Id: 87106
Status: resolved
Priority: 0/
Queue: Business-Hours

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.10



Subject: t/99-pod.t fails due to non-escaped slash in the link
0.10 POD test fails with perl 5.18 that has stricter POD parser: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1-business-hours.t .. ok t/2-holidays.t ........ ok t/99-pod-coverage.t ... ok t/99-pod.t ............ 1/1 # Failed test 'POD test for blib/lib/Business/Hours.pm' # at /usr/share/perl5/vendor_perl/Test/Pod.pm line 186. # blib/lib/Business/Hours.pm (157): alternative text '/"holidays ARRAY"' contains non-escaped | or / # blib/lib/Business/Hours.pm (179): alternative text '/"business_hours HASH"' contains non-escaped | or / # Looks like you failed 1 test of 1. t/99-pod.t ............ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
From: ppisar [...] redhat.com
Dne So 20.čec.2013 11:53:57, ppisar napsal(a): Show quoted text
> 0.10 POD test fails with perl 5.18 that has stricter POD parser:
Fix is attached. -- Petr
Subject: Business-Hours-0.10-Fix-POD-syntax.patch
From 8ba47e61ff99b7225445224149f89d376dd6bda7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Sat, 20 Jul 2013 17:53:47 +0200 Subject: [PATCH] Fix POD syntax MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=87106> Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/Business/Hours.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Business/Hours.pm b/lib/Business/Hours.pm index 28704cf..28c967e 100644 --- a/lib/Business/Hours.pm +++ b/lib/Business/Hours.pm @@ -154,7 +154,7 @@ an array reference value, for example: holidays => [qw(01-01 12-25 2009-05-08)], ); -Read more about holidays specification below in L</"holidays ARRAY"|holidays>. +Read more about holidays specification below in L<"holidays ARRAY"|holidays>. =cut @@ -176,7 +176,7 @@ Specification with year defined may be required when a holiday matches Sunday or Saturday. In many countries days are shifted in such case. -Holidays can be set via L</"business_hours HASH"|business_hours> method +Holidays can be set via L<"business_hours HASH"|business_hours> method as well, so you can use this feature without changing your code. =cut -- 1.8.1.4
Subject: Re: [rt.cpan.org #87106] t/99-pod.t fails due to non-escaped slash in the link
Date: Sat, 20 Jul 2013 12:06:32 -0400
To: bug-Business-Hours [...] rt.cpan.org
From: Alex Vandiver <alex [...] chmrr.net>
On Sat, 2013-07-20 at 11:59 -0400, Petr Pisar via RT wrote: Show quoted text
> Queue: Business-Hours > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87106 > > > Dne So 20.čec.2013 11:53:57, ppisar napsal(a):
> > 0.10 POD test fails with perl 5.18 that has stricter POD parser:
> > Fix is attached.
Thanks for the report. I've pushed a slightly more correct fix, and 0.11 will be on its way to PAUSE shortly. - Alex