Bug #87029 for DBI: Possible precedence issue with control flow operator at ./t/16destroy.t

Thu Jul 18 16:55:05 2013 rurban [...] x-ray.at - Ticket created

Subject:

Possible precedence issue with control flow operator at ./t/16destroy.t

With the patches in [perl #59802] applied the following construct is warned: < exit $self->FETCH('Active') || 0 unless $^O eq 'MSWin32'; Show quoted text

> exit ($self->FETCH('Active') || 0) unless $^O eq 'MSWin32';

t/zvxgp_15array.t ............... ok Possible precedence issue with control flow operator at ./t/16destroy.t line 81. t/zvxgp_16destroy.t ............. ok Please add the parens to improve the readability.

Thu Jul 18 17:00:20 2013 rurban [...] x-ray.at - Correspondence added

From:

rurban [...] x-ray.at

exit is a unary operator. named unary operators have arithmetic precedence, i.e. tighter than || On Thu Jul 18 16:55:05 2013, rurban@x-ray.at wrote: Show quoted text

> With the patches in [perl #59802] applied the following construct is > warned: > > < exit $self->FETCH('Active') || 0 unless $^O eq 'MSWin32';

> > exit ($self->FETCH('Active') || 0) unless $^O eq 'MSWin32';

> > t/zvxgp_15array.t ............... ok > Possible precedence issue with control flow operator at > ./t/16destroy.t line 81. > t/zvxgp_16destroy.t ............. ok > > Please add the parens to improve the readability.

Fri Jul 19 07:33:43 2013 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #87029] Possible precedence issue with control flow operator at ./t/16destroy.t
Date:	Fri, 19 Jul 2013 13:33:23 +0200
To:	bug-DBI [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Thu, 18 Jul 2013 17:00:20 -0400, "Reini Urban via RT" <bug-DBI@rt.cpan.org> wrote: Show quoted text

> Queue: DBI > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=87029 > > > exit is a unary operator. > named unary operators have arithmetic precedence, i.e. tighter than ||

Thanks. Parens added as suggested. Closing ticket. -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Fri Jul 19 07:33:43 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 19 08:31:05 2013 HMBRAND [...] cpan.org - Broken in 1.613_71 added

Fri Jul 19 08:31:06 2013 HMBRAND [...] cpan.org - Broken in 1.627_94 deleted

Fri Jul 19 08:31:06 2013 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Sat Jan 25 10:29:00 2014 TIMB [...] cpan.org - Correspondence added

Fixed in 1.631. Thanks!

Sat Jan 25 10:29:01 2014 TIMB [...] cpan.org - Status changed from 'patched' to 'resolved'