Bug #86978 for RT-Extension-ExtractCustomFieldValues: [Patch] add option to extract multiple values

Tue Jul 16 18:29:23 2013 kriggle [...] akamai.com - Ticket created

Subject:	[Patch] add option to extract multiple values
Date:	Tue, 16 Jul 2013 18:29:10 -0400
To:	"bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org" <bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org>
From:	"Riggle, Kevin" <kriggle [...] akamai.com>

One of the things I've needed for my use of RT::Extension::ExtractCustomFieldValues is the ability to extract multiple values from the same header into a multiple value CF, eg. pulling two or three subject tags out of the same Subject: header. I've attached the patch I cooked up to do it, which includes documentation describing its behavior further. I've been running with it in place for a few weeks and haven't encountered any problems so far. (The patch is based on 633739c9 from the Github repository. I'm not quite sure how you prefer taking patches these days -- I can file a pull request if you'd rather.) Best, - Kevin

Message body is not shown because sender requested not to inline it.

Tue Jul 23 20:28:17 2013 trs [...] bestpractical.com - Correspondence added

Subject:	Re: [rt.cpan.org #86978] [Patch] add option to extract multiple values
Date:	Tue, 23 Jul 2013 17:28:15 -0700
To:	bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org
From:	Thomas Sibley <trs [...] bestpractical.com>

On 07/16/2013 03:29 PM, Riggle, Kevin via RT wrote: Show quoted text

> One of the things I've needed for my use of > RT::Extension::ExtractCustomFieldValues is the ability to extract multiple > values from the same header into a multiple value CF, eg. pulling two or > three subject tags out of the same Subject: header. I've attached the > patch I cooked up to do it, which includes documentation describing its > behavior further. I've been running with it in place for a few weeks and > haven't encountered any problems so far.

The patch you sent needs a little tweaking before being applied. Notably: • Doc was added to the README, but it's generated from the POD in the extension's primary lib file. The doc needs to go into the POD instead, not the README directly. • The match needs to be surrounded by a capture group for $2 || $1 to make sense. Show quoted text

> (The patch is based on 633739c9 from the Github repository. I'm not quite > sure how you prefer taking patches these days -- I can file a pull request > if you'd rather.)

Patches and pull requests are both great.

Tue Jul 23 20:28:17 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 30 18:01:18 2013 kriggle [...] akamai.com - Correspondence added

Subject:	Re: [rt.cpan.org #86978] [Patch] add option to extract multiple values
Date:	Tue, 30 Jul 2013 17:01:00 -0500
To:	"bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org" <bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org>
From:	"Riggle, Kevin" <kriggle [...] akamai.com>

Updated patch attached. Thanks! - Kevin On 2013-7-23 8:28 PM, "trs@bestpractical.com via RT" <bug-RT-Extension-ExtractCustomFieldValues@rt.cpan.org> wrote: Show quoted text

><URL: https://rt.cpan.org/Ticket/Display.html?id=86978 > > >On 07/16/2013 03:29 PM, Riggle, Kevin via RT wrote:

>> One of the things I've needed for my use of >> RT::Extension::ExtractCustomFieldValues is the ability to extract >>multiple >> values from the same header into a multiple value CF, eg. pulling two or >> three subject tags out of the same Subject: header. I've attached the >> patch I cooked up to do it, which includes documentation describing its >> behavior further. I've been running with it in place for a few weeks >>and >> haven't encountered any problems so far.

> >The patch you sent needs a little tweaking before being applied. Notably: > >• Doc was added to the README, but it's generated from the POD in the >extension's primary lib file. The doc needs to go into the POD instead, >not the README directly. > >• The match needs to be surrounded by a capture group for $2 || $1 to >make sense. >

>> (The patch is based on 633739c9 from the Github repository. I'm not >>quite >> sure how you prefer taking patches these days -- I can file a pull >>request >> if you'd rather.)

> >Patches and pull requests are both great. >

Message body is not shown because sender requested not to inline it.

Tue Jul 30 20:53:54 2013 tsibley [...] cpan.org - Correspondence added

Thanks! Applied and released as 3.08.

Tue Jul 30 20:53:55 2013 tsibley [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jul 30 23:19:12 2013 trs [...] bestpractical.com - Correspondence added

Subject:	Re: [rt.cpan.org #86978] [Patch] add option to extract multiple values
Date:	Tue, 30 Jul 2013 20:19:08 -0700
To:	"bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org" <bug-RT-Extension-ExtractCustomFieldValues [...] rt.cpan.org>
From:	Thomas Sibley <trs [...] bestpractical.com>

It'll be in 3.09 instead; there were permission issues with 3.08.