| CC: | perltidy [...] users.sourceforge.net, bug-Perl-Tidy [...] rt.cpan.org |
| Subject: | Re: [perl #118911] Bleadperl v5.19.1-250-g60282a4 breaks SHANCOCK/Perl-Tidy-20121207.tar.gz |
| Date: | Mon, 15 Jul 2013 08:16:05 +0200 |
| To: | perl5-porters [...] perl.org |
| From: | Lukas Mai <plokinom [...] gmail.com> |
On 15.07.2013 07:38, (Andreas J. Koenig) (via RT) wrote:
Show quoted text
>
> git bisect
> ----------
> commit 60282a494b5eb9b1c93b895d1cc5849b1d17d28a
> Author: Karl Williamson <public@khwilliamson.com>
> Date: Thu Jul 4 16:00:45 2013 -0600
>
> PATCH: [perl #114178] di/ds/ig exempt from warnings in void context
>
> diagnostics
> -----------
> All tests pass but loading Perl::Tidy is now noisy, which then in turn
> affects e.g. HMBRAND/Data-Peek-0.38.tgz
>
> PERL_DL_NONLAZY=1 /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.1-250-g60282a4/127e/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
> t/test.t .... Useless use of a constant ("division (no end to pattern foun"...) in void context at /tmp/loop_over_bdir-17160-7iPpbR/Perl-Tidy-20121207-dxBGOy/blib/lib/Perl/Tidy.pm line 27326.
> t/test.t .... ok
> t/testsa.t .. Useless use of a constant ("division (no end to pattern foun"...) in void context at /tmp/loop_over_bdir-17160-7iPpbR/Perl-Tidy-20121207-dxBGOy/blib/lib/Perl/Tidy.pm line 27326.
> t/testsa.t .. ok
> t/testss.t .. Useless use of a constant ("division (no end to pattern foun"...) in void context at /tmp/loop_over_bdir-17160-7iPpbR/Perl-Tidy-20121207-dxBGOy/blib/lib/Perl/Tidy.pm line 27326.
> t/testss.t .. ok
> All tests successful.
>
> The lines 27325..27327 are
>
> if ( $i >= $max_token_index ) {
> "division (no end to pattern found on the line)\n";
> }
This is obviously a bug in Perl::Tidy that was masked by perl not
warning for strings literals matching /^di/.
--
Lukas Mai <plokinom@gmail.com>