Bug #86890 for parent: Tests fails with perl 5.18.0

Fri Jul 12 08:30:17 2013 ppisar [...] redhat.com - Ticket created

Subject:

Tests fails with perl 5.18.0

Perl 5.18.0 has changes error message: $ perl -e 'use parent q{reallyReAlLyNotexists}' Can't locate reallyReAlLyNotexists.pm in @INC (you may need to install the reallyReAlLyNotexists module) (@INC contains:... Thus t/parent.t fails. This is fixed in perl git tree with commit: commit f7ee53b55241648302d3da2fac688b5a0d595fd7 Author: Paul Johnson <paul@pjcj.net> Date: Wed Sep 26 02:44:45 2012 +0200 Suggest cause of error requiring .pm file. Following on from a recent thread I've put together a patch to expand the error message when a module can't be loaded. With this patch, instead of: Can't locate Stuff/Of/Dreams.pm in @INC (@INC contains: ...) You get: Can't locate Stuff/Of/Dreams.pm in @INC (you may need to install the Stuff:: [The committer tweaked the error message, based on a suggestion by Tony Cook. See <https://rt.perl.org/rt3/Ticket/Display.html?id=115048#txn-1157750>.] Please apply the change.

Fri Jul 12 08:51:10 2013 ppisar [...] redhat.com - Correspondence added

From:

ppisar [...] redhat.com

Dne Pá 12.čec.2013 08:30:17, ppisar napsal(a): Show quoted text

> Perl 5.18.0 has changes error message: > > $ perl -e 'use parent q{reallyReAlLyNotexists}' > Can't locate reallyReAlLyNotexists.pm in @INC (you may need to install > the reallyReAlLyNotexists module) (@INC contains:... > > Thus t/parent.t fails. >

Attached patch is backward compatible.

Subject:

parent-0.225-Perl-5.18.0-has-changed-error-message.patch

From a8d39e4eb350fb1a30fcbdbb3f8f110fe2a708fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Fri, 12 Jul 2013 14:32:28 +0200 Subject: [PATCH] Perl 5.18.0 has changed error message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <https://rt.cpan.org/Public/Bug/Display.html?id=86890> Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com> --- t/parent.t | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/t/parent.t b/t/parent.t index 401fe39..f3b8533 100755 --- a/t/parent.t +++ b/t/parent.t @@ -58,10 +58,18 @@ is( $Eval2::VERSION, '1.02' ); eval q{use parent 'reallyReAlLyNotexists'}; -like( $@, q{/^Can't locate reallyReAlLyNotexists.pm in \@INC $\@INC contains:/}, 'baseclass that does not exist'); +like( $@, + ($] < 5.018) ? + q{/^Can't locate reallyReAlLyNotexists.pm in \@INC \(\@INC contains:/} : + q{/^Can't locate reallyReAlLyNotexists.pm in \@INC \(you may need to install the reallyReAlLyNotexists module$ $\@INC contains:/}, + 'baseclass that does not exist'); eval q{use parent 'reallyReAlLyNotexists'}; -like( $@, q{/^Can't locate reallyReAlLyNotexists.pm in \@INC \(\@INC contains:/}, ' still failing on 2nd load'); +like( $@, + ($] < 5.018) ? + q{/^Can't locate reallyReAlLyNotexists.pm in \@INC \(\@INC contains:/} : + q{/^Can't locate reallyReAlLyNotexists.pm in \@INC \(you may need to install the reallyReAlLyNotexists module$ \(\@INC contains:/}, + ' still failing on 2nd load'); { my $warning; local $SIG{__WARN__} = sub { $warning = shift }; -- 1.8.1.4

Mon Jul 29 14:40:37 2013 corion [...] cpan.org - Correspondence added

Thanks for the report! I've just released 0.226, which fixes the test! -max

Mon Jul 29 14:40:38 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 29 14:40:38 2013 corion [...] cpan.org - Status changed from 'open' to 'resolved'